Skip to content

Attempt to come up with a more scalable approach to logging. #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 27, 2024

Conversation

AdvancedImagingUTSW
Copy link
Collaborator

Let me know what you think...

The only thing I don't like is that the logging reports the location of the decorator, not the class itself...

2024-09-26 11:00:04,258 - controller - INFO - decorators: 'StageController' Initialized

Also make the naming consistent.
String representation of MainApp causes tests to fail.
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 85 lines in your changes missing coverage. Please review.

Project coverage is 53.65%. Comparing base (9120c03) to head (e0e0416).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
src/navigate/model/features/common_features.py 22.22% 14 Missing ⚠️
src/navigate/model/model.py 36.84% 12 Missing ⚠️
src/navigate/plugins/plugin_manager.py 28.57% 10 Missing ⚠️
src/navigate/model/devices/APIs/sutter/MP285.py 0.00% 6 Missing ⚠️
src/navigate/model/devices/camera/hamamatsu.py 0.00% 6 Missing ⚠️
src/navigate/model/devices/camera/photometrics.py 0.00% 3 Missing ⚠️
src/navigate/model/features/image_writer.py 72.72% 3 Missing ⚠️
...ate/model/devices/APIs/asi/asi_tiger_controller.py 0.00% 2 Missing ⚠️
src/navigate/model/devices/daq/ni.py 0.00% 2 Missing ⚠️
src/navigate/model/devices/filter_wheel/ni.py 0.00% 2 Missing ⚠️
... and 17 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1000      +/-   ##
===========================================
+ Coverage    53.54%   53.65%   +0.11%     
===========================================
  Files          178      178              
  Lines        19959    20032      +73     
===========================================
+ Hits         10687    10749      +62     
- Misses        9272     9283      +11     
Flag Coverage Δ
unittests 53.65% <64.28%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…mation such as available RAM, writing rates, devices, configuration, etc.
They never worked. Currently just commented out.
@AdvancedImagingUTSW AdvancedImagingUTSW marked this pull request as ready for review September 27, 2024 22:44
@AdvancedImagingUTSW AdvancedImagingUTSW merged commit eb8bf7b into develop Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant