Small fixes... #1019
Merged
Small fixes... #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configurator - scaled back the warning since it seems to be working nicely. controller - very small type hinting changes. camera_view - Extracted some code to make a method that we can call elsewhere. `self.get_selected_channels`, some typehinting, cleaned up some warnings for things like uncalled parameters (*args), and fixed a few bugs that would occur with the MIP view. Several widgets converted to readonly. Attributes initialized. Edge case handling. configurator_application_window - make some comboboxes readonly, changed one method name. display_notebook - made some comboboxes readonly acquire_popup - made some comboboxes readonly
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1019 +/- ##
===========================================
+ Coverage 54.05% 54.24% +0.18%
===========================================
Files 180 180
Lines 20250 20274 +24
===========================================
+ Hits 10946 10997 +51
+ Misses 9304 9277 -27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
annie-xd-wang
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configurator - scaled back the warning since it seems to be working nicely.
controller - very small type hinting changes.
camera_view - Extracted some code to make a method that we can call elsewhere.
self.get_selected_channels, some typehinting, cleaned up some warnings for things like uncalled parameters (*args), and fixed a few bugs that would occur with the MIP view. Several widgets converted to readonly. Attributes initialized. Edge case handling.configurator_application_window - make some comboboxes readonly, changed one method name.
display_notebook - made some comboboxes readonly
acquire_popup - made some comboboxes readonly