Skip to content

Update microscope.py #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Update microscope.py #1026

merged 2 commits into from
Nov 7, 2024

Conversation

AdvancedImagingUTSW
Copy link
Collaborator

Added type annotations, and extracted a few methods to make some of the code a bit more readable.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 84.78261% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.31%. Comparing base (365fbad) to head (422f5ea).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
src/navigate/model/microscope.py 84.78% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1026      +/-   ##
===========================================
+ Coverage    54.30%   54.31%   +0.01%     
===========================================
  Files          180      180              
  Lines        20302    20319      +17     
===========================================
+ Hits         11025    11037      +12     
- Misses        9277     9282       +5     
Flag Coverage Δ
unittests 54.31% <84.78%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdvancedImagingUTSW AdvancedImagingUTSW merged commit f9b3532 into develop Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants