Speedup Histogram - Small Bug Fix #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To accelerate the histogram, which some have complained causes the program to be laggy, I now only use 1/8th of the data coming off the camera to create the histogram. Seems fairly responsive on BT-MesoSPIM. Also, @samcal06 found that if no channel settings are selected in the GUI, and we start up the software, setting the selected channel in the render_widgets of the camera_view controllers throws an error.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1029 +/- ##
========================================
Coverage 54.29% 54.29%
========================================
Files 180 180
Lines 20302 20306 +4
========================================
+ Hits 11023 11026 +3
- Misses 9279 9280 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
annie-xd-wang
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To accelerate the histogram, which some have complained causes the program to be laggy, I now only use 1/8th of the data coming off the camera to create the histogram. Seems fairly responsive on BT-MesoSPIM.
Also, @samcal06 found that if no channel settings are selected in the GUI, and we start up the software, setting the selected channel in the render_widgets of the camera_view controllers throws an error.