Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenience Hotkeys, Some Tk cleanup, and type hints. #1051

Merged
merged 5 commits into from
Dec 23, 2024

Conversation

AdvancedImagingUTSW
Copy link
Collaborator

No description provided.

Escape to close windows, new menu entry for quitting, adding shortcuts to stage tab.
Adjusted the stage tab to include short cuts for setting the start and stop positions of a z-stack. This needs to be tested.

Also went through and cleaned up the channels_tab.py module to include typehints. One significant change included removing the call_parent input argument from update_timepoint_settings. This was unused...
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 85.83333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 54.26%. Comparing base (9becea1) to head (1b080bf).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
...avigate/controller/sub_controllers/channels_tab.py 81.57% 7 Missing ⚠️
...c/navigate/controller/sub_controllers/autofocus.py 81.81% 4 Missing ⚠️
...igate/controller/sub_controllers/waveform_popup.py 50.00% 4 Missing ⚠️
src/navigate/controller/sub_controllers/tiling.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1051      +/-   ##
===========================================
- Coverage    54.43%   54.26%   -0.18%     
===========================================
  Files          184      184              
  Lines        20893    21002     +109     
===========================================
+ Hits         11374    11397      +23     
- Misses        9519     9605      +86     
Flag Coverage Δ
unittests 54.26% <85.83%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdvancedImagingUTSW AdvancedImagingUTSW merged commit 90c5160 into develop Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants