Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo & Naming #1063

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Typo & Naming #1063

merged 3 commits into from
Feb 24, 2025

Conversation

AdvancedImagingUTSW
Copy link
Collaborator

The laser ni class had a typo from the recent import.

Also found that the photometrics class was riddled with things that don't adhere to our naming styles. Updated and will test. Also added another note to the documentation about the most recent version of the PVCAM library.

I'm also not sure if there is a better way to handle the pyvcam library. Currently, people would have to locally install the library.

The laser ni class had a typo from the recent import.

Also found that the photometrics class was riddled with things that don't adhere to our naming styles. Updated and will test. Also added another note to the documentation about the most recent version of the PVCAM library.
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 7.89474% with 35 lines in your changes missing coverage. Please review.

Project coverage is 55.30%. Comparing base (71a10fa) to head (17ff65e).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
src/navigate/model/devices/camera/photometrics.py 0.00% 31 Missing ⚠️
src/navigate/model/devices/laser/ni.py 0.00% 3 Missing ⚠️
src/navigate/model/devices/device_types.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1063      +/-   ##
===========================================
- Coverage    55.77%   55.30%   -0.47%     
===========================================
  Files          181      182       +1     
  Lines        20303    20473     +170     
===========================================
  Hits         11323    11323              
- Misses        8980     9150     +170     
Flag Coverage Δ
unittests 55.30% <7.89%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdvancedImagingUTSW AdvancedImagingUTSW merged commit 9ffa4f8 into develop Feb 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants