Shutter Pull Request #1092
Merged
Shutter Pull Request #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Digital On/Off added to API
turns lasers on and off, sets the lasers power
ASI Shutter passing all tests on our side.
Added single axis commands in Navigate, both for creating the waveforms, and initiating the axis output.
As discussed with Dr Dean, minor changes to be more agreeable with Navigate and code formatting.
adds the plc commands to the lasers
Changes stuff. You should check it out
Shutter-Pull-Requests changes
Shutter pull request
There was a problem hiding this comment.
Pull Request Overview
This pull request implements shutter control changes for ASI devices by adding a dedicated shutter class and corresponding API controller methods, along with updating configuration options.
- Introduces the ASIShutter class with methods to connect, open, and close the shutter.
- Adds logic_card_on and logic_card_off methods to the TigerController API for shutter operations.
- Updates configuration widgets with "port" and "axis" options to support shutter hardware settings.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/navigate/model/devices/shutter/asi.py | Added ASIShutter class and shutter control methods |
| src/navigate/model/devices/APIs/asi/asi_tiger_controller.py | Added logic for turning the logic card on and off |
| src/navigate/config/configuration_database.py | Included new configuration keys for ASI shutter hardware |
Comments suppressed due to low confidence (2)
src/navigate/model/devices/shutter/asi.py:49
- The class docstring describes this as 'ShutterTTL Class' which is inconsistent with the class name ASIShutter. Please update the docstring for clarity.
class ASIShutter(ShutterBase, SerialDevice):
src/navigate/model/devices/APIs/asi/asi_tiger_controller.py:942
- [nitpick] The parameter 'axis' is annotated as a string, but it is immediately converted to an integer for offset calculation. Consider updating the type hint to int for clarity.
def logic_card_on(self, axis : str):
AdvancedImagingUTSW
approved these changes
Apr 25, 2025
|
Ideally, future PRs will include the changes to the documentation that outline that this device is available @Daniel-Buckelew. Otherwise, looks great. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for the shutter changes from etagivan.