-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-chain: Reserve transfer #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three types of reserve transfers and we support all of them:
limitedReserveTransfer
extrinsic that is part of the XCM pallet.WithdrawAsset
, withdraw the amount the user wants to transfer from the sending chain and put it into the holding registerInitiateReserveWithdraw
, this will take all the assets in the holding register and burn them on the origin chain. This will put the appropriate amount into the holding register on the reserve chain.BuyExecution
DepositAsset
into the receiver accountThe instructions are essentially the same as in the previous case, the only difference being that instead of using
DepositAsset
instruction on the reserve chain directly we first callDepositReserveAsset
to deposit into the parachain sovereign account, and send aDepositAsset
instruction to the receiver chain that will actually place the newly received tokens into the receiver account.NOTE: This PR only allows fee payment with the asset that is being transferred. A separate PR will be opened that will allow fee payment with the relay chain's native currency.
Closes: #30