Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xcmInteriorKey conversion #53

Merged
merged 2 commits into from
Aug 20, 2023
Merged

Fix xcmInteriorKey conversion #53

merged 2 commits into from
Aug 20, 2023

Conversation

Szegoo
Copy link
Member

@Szegoo Szegoo commented Aug 10, 2023

There was a problem in the code in case the asset is on a parachain itself. In this case, the result would still specify the parachain junction, but that is not correct, since from the perspective of the parachain only the other junctions need to be specified.

Also, removed the test for getting all the assets on Acala, since the assets change pretty frequently.

@Szegoo Szegoo requested a review from cuteolaf August 10, 2023 22:44
@cuteolaf cuteolaf merged commit 2f87e6b into main Aug 20, 2023
7 checks passed
@cuteolaf cuteolaf deleted the fix-xcm-conversion branch August 20, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants