Skip to content

Commit

Permalink
fix issue with disabled migrate button (#137) (#138)
Browse files Browse the repository at this point in the history
* fix issue with disabled migrate button (#137)

* test button

* Update ModuleChangelog.md

Co-authored-by: Joe Workman <54448601+jworkmanjc@users.noreply.github.com>

* Update ModuleChangelog.md

Co-authored-by: Joe Workman <54448601+jworkmanjc@users.noreply.github.com>

---------

Co-authored-by: Joe Workman <54448601+jworkmanjc@users.noreply.github.com>
  • Loading branch information
kmaranionjc and jworkmanjc authored Aug 29, 2024
1 parent f288179 commit 6599125
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 9 deletions.
14 changes: 13 additions & 1 deletion ModuleChangelog.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,21 @@
## 2.7.5
## 2.7.6

Release Date: August 21, 2024

#### RELEASE NOTES

This fixes an issue with disabled Migrate Button

#### Bug Fixes:
```
* Fixed an issue with ADMU UI "Migrate Profile" button where it remained disabled even though all the required fields were satisfied.
```
## 2.7.5

Release Date: August 28, 2024

#### RELEASE NOTES

This release reverts changes from 2.7.4 in the UWP app, specifically the xaml form was reverted back to the original windows form to display progress of the Appx/ File Association during first boot. This release adds additional logging to the UWP app.

#### Bug Fixes:
Expand Down
2 changes: 1 addition & 1 deletion jumpcloud-ADMU/JumpCloud.ADMU.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

# Version number of this module.

ModuleVersion = '2.7.5'
ModuleVersion = '2.7.6'

# Supported PSEditions
# CompatiblePSEditions = @()
Expand Down
10 changes: 5 additions & 5 deletions jumpcloud-ADMU/Powershell/Form.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ function show-mtpSelection {
<Window
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
Title="JumpCloud ADMU 2.7.5"
Title="JumpCloud ADMU 2.7.6"
WindowStyle="SingleBorderWindow"
ResizeMode="NoResize"
Background="White" ScrollViewer.VerticalScrollBarVisibility="Visible" ScrollViewer.HorizontalScrollBarVisibility="Visible" Width="1020" Height="590">
Expand Down Expand Up @@ -628,7 +628,7 @@ $cb_autobindjcuser.Add_Checked( { $img_apikey_valid.Visibility = 'Visible' })
$cb_autobindjcuser.Add_Checked( { $cb_bindAsAdmin.IsEnabled = $true })
$cb_bindAsAdmin.Add_Checked( { $script:BindAsAdmin = $true })
$cb_autobindjcuser.Add_Checked( {
Test-Button -tbJumpCloudUserName:($tbJumpCloudUserName) -tbJumpCloudConnectKey:($tbJumpCloudConnectKey) -tbJumpCloudConnectAPIKey:($tbJumpCloudAPIKey) -tbTempPassword:($tbTempPassword) -lvProfileList:($lvProfileList) -tbJumpCloudAPIKey:($tbJumpCloudAPIKey)
Test-Button -tbJumpCloudUserName:($tbJumpCloudUserName) -tbJumpCloudConnectKey:($tbJumpCloudConnectKey) -tbTempPassword:($tbTempPassword) -lvProfileList:($lvProfileList) -tbJumpCloudAPIKey:($tbJumpCloudAPIKey)
If (((Test-CharLen -len 40 -testString $tbJumpCloudAPIKey.Password) -and (Test-HasNoSpace $tbJumpCloudAPIKey.Password)) -eq $false) {
#$tbJumpCloudAPIKey.Tooltip = "API Key Must be 40chars & Not Contain Spaces"
$tbJumpCloudAPIKey.Background = "#FFC6CBCF"
Expand All @@ -651,7 +651,7 @@ $cb_autobindjcuser.Add_Unchecked( { $cb_bindAsAdmin.IsEnabled = $false })
$cb_autobindjcuser.Add_Unchecked( { $cb_bindAsAdmin.IsChecked = $false })
$cb_bindAsAdmin.Add_Unchecked( { $script:BindAsAdmin = $false })
$cb_autobindjcuser.Add_Unchecked( {
Test-Button -tbJumpCloudUserName:($tbJumpCloudUserName) -tbJumpCloudConnectKey:($tbJumpCloudConnectKey) -tbJumpCloudConnectAPIKey:($tbJumpCloudAPIKey) -tbTempPassword:($tbTempPassword) -lvProfileList:($lvProfileList) -tbJumpCloudAPIKey:($tbJumpCloudAPIKey)
Test-Button -tbJumpCloudUserName:($tbJumpCloudUserName) -tbJumpCloudConnectKey:($tbJumpCloudConnectKey) -tbTempPassword:($tbTempPassword) -lvProfileList:($lvProfileList) -tbJumpCloudAPIKey:($tbJumpCloudAPIKey)
If (((Test-CharLen -len 40 -testString $tbJumpCloudAPIKey.Password) -and (Test-HasNoSpace $tbJumpCloudAPIKey.Password) -or ($cb_autobindjcuser.IsEnabled)) -eq $false) {
#$tbJumpCloudAPIKey.Tooltip = "API Key Must be 40chars & Not Contain Spaces"
$tbJumpCloudAPIKey.Background = "#FFC6CBCF"
Expand Down Expand Up @@ -720,8 +720,7 @@ $tbJumpCloudConnectKey.Add_PasswordChanged( {
})

$tbJumpCloudAPIKey.Add_PasswordChanged( {
Test-Button -tbJumpCloudUserName:($tbJumpCloudUserName) -tbJumpCloudConnectKey:($tbJumpCloudConnectKey) -tbJumpCloudConnectAPIKey:($tbJumpCloudAPIKey) -tbTempPassword:($tbTempPassword) -lvProfileList:($lvProfileList) -tbJumpCloudAPIKey:($tbJumpCloudAPIKey)

Test-Button -tbJumpCloudUserName:($tbJumpCloudUserName) -tbJumpCloudConnectKey:($tbJumpCloudConnectKey) -tbTempPassword:($tbTempPassword) -lvProfileList:($lvProfileList) -tbJumpCloudAPIKey:($tbJumpCloudAPIKey)
If (((Test-CharLen -len 40 -testString $tbJumpCloudAPIKey.Password) -and (Test-HasNoSpace $tbJumpCloudAPIKey.Password)) -eq $false) {
$tbJumpCloudAPIKey.Background = "#FFC6CBCF"
$tbJumpCloudAPIKey.BorderBrush = "#FFF90000"
Expand All @@ -740,6 +739,7 @@ $tbJumpCloudAPIKey.Add_PasswordChanged( {
$tbJumpCloudAPIKey.BorderBrush = "#FFC6CBCF"
$img_apikey_valid.Source = DecodeBase64Image -ImageBase64 $ActiveBase64
$img_apikey_valid.ToolTip = $null
Test-Button -tbJumpCloudUserName:($tbJumpCloudUserName) -tbJumpCloudConnectKey:($tbJumpCloudConnectKey) -tbTempPassword:($tbTempPassword) -lvProfileList:($lvProfileList) -tbJumpCloudAPIKey:($tbJumpCloudAPIKey)
} catch {
$OrgSelection = ""
$lbl_orgName.Text = ""
Expand Down
2 changes: 1 addition & 1 deletion jumpcloud-ADMU/Powershell/ProgressForm.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function New-ProgressForm {
<Window
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
Name="Window" Title="JumpCloud ADMU 2.7.5"
Name="Window" Title="JumpCloud ADMU 2.7.6"
WindowStyle="SingleBorderWindow"
ResizeMode="NoResize"
Background="White" Width="720" Height="550 ">
Expand Down
2 changes: 1 addition & 1 deletion jumpcloud-ADMU/Powershell/Start-Migration.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -1883,7 +1883,7 @@ Function Start-Migration {
$AGENT_INSTALLER_URL = "https://cdn02.jumpcloud.com/production/jcagent-msi-signed.msi"
$AGENT_INSTALLER_PATH = "$windowsDrive\windows\Temp\JCADMU\jcagent-msi-signed.msi"
$AGENT_CONF_PATH = "$($AGENT_PATH)\Plugins\Contrib\jcagent.conf"
$admuVersion = '2.7.5'
$admuVersion = '2.7.6'

$script:AdminDebug = $AdminDebug
$isForm = $PSCmdlet.ParameterSetName -eq "form"
Expand Down

0 comments on commit 6599125

Please sign in to comment.