Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sa 3041 retain default app protocol associations #105

Merged
merged 72 commits into from
Feb 7, 2024

Conversation

kmaranionjc
Copy link
Contributor

@kmaranionjc kmaranionjc commented Jan 23, 2024

Issues

  • SA-3041 - SA-3041-Retain-Default-App-Protocol-Associations
  • SA-3822 - CUT-3822-LoadHiveBug

What does this solve?

  • Added migration of default apps/file type associations(ex. .txt, html, mp3) and protocol type associations(ex. FTP, HTTP)
  • Added a fix to stop/revert migration when a registry hive fails to load

Is there anything particularly tricky?

Migrated user is unable to run unsigned uwp_jcadmu.exe unless the migrated user is an administrator.

How should this be tested?

FTA/PTA Test:
PRE-MIGRATION:

  1. Change the couple of default apps to your AD user's account such as default browser or text file application in Settings->Apps->Default Apps
  2. While in Default Apps settings, use the search bar to search for a protocol such as FTP, HTTP, HTTPS. Change the default value.
  3. Sign out then migrate
    POST-MIGRATION
  4. Create a uwp_jcadmu.exe file:
  • In powershell CD to C:\Users\YOURUSER\Downloads\JCADMUBranch\Deploy
  • Run this command to create .exe:
    Invoke-ps2exe -inputFile .\uwp_jcadmu.ps1 -outputFile .\uwp_jcadmu.exe -title 'JumpCloud ADMU' -product 'JumpCloud ADMU' -description 'JumpCloud AD Migration Utility' -copyright "(c) $year" -version “2.6.0” -company 'JumpCloud' -requireAdmin -iconfile '.\admu.ico'
  1. After creating the uwp_jcadmu.exe move it to C:\Windows
  2. From my tests, I have an issue with non-admin user running the uwp_jcadmu.exe due to it being unsigned. My workaround testing until we get a signed file is to set the migrated user as an admin for the file to run properly.
  3. Validate the changes on the migrated user's Default Apps settings
    image
  4. Validate the CSV files and logs created
    image

Load Hive Bug Test:

  1. Change the REG LOAD path to a nonexistent path for line 417 or 418 in Set-UserRegistryLoadState function
  2. Run migration
  3. Validate that it should throw an error

@kmaranionjc kmaranionjc requested a review from a team as a code owner January 23, 2024 23:09
@kmaranionjc kmaranionjc added ADMU ADMU Module Release patch Patch version release labels Jan 23, 2024
@kmaranionjc kmaranionjc added minor Minor Version Release and removed patch Patch version release labels Jan 24, 2024
@kmaranionjc kmaranionjc changed the base branch from master to v2.6.0 January 26, 2024 18:18
jumpcloud-ADMU/Powershell/Start-Migration.ps1 Outdated Show resolved Hide resolved
jumpcloud-ADMU/Powershell/Start-Migration.ps1 Outdated Show resolved Hide resolved
jumpcloud-ADMU/Powershell/Start-Migration.ps1 Outdated Show resolved Hide resolved
jumpcloud-ADMU/Powershell/Tests/FtaPta.Tests.ps1 Outdated Show resolved Hide resolved
Deploy/uwp_jcadmu.ps1 Outdated Show resolved Hide resolved
Copy link
Contributor

@jworkmanjc jworkmanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few thoughts on functions tests and cleanup. Do we need the FtaPta Tests file? any reason to keep that whole commented out file in our repo?

@kmaranionjc kmaranionjc requested a review from gweinjc February 7, 2024 19:36
@kmaranionjc kmaranionjc self-assigned this Feb 7, 2024
jworkmanjc
jworkmanjc previously approved these changes Feb 7, 2024
Copy link
Contributor

@jworkmanjc jworkmanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup work here and all the changes. Approved, we'll do one more test before we publish the draft release but after testing migration one more time I can confirm that my default app settings were retained post-migration!

gweinjc
gweinjc previously approved these changes Feb 7, 2024
Copy link
Contributor

@gweinjc gweinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finished testing on my end. Looks like the user's default apps are carrying over as expected. Nice job!

@kmaranionjc kmaranionjc dismissed stale reviews from gweinjc and jworkmanjc via d05a9c8 February 7, 2024 21:24
Copy link
Contributor

@jworkmanjc jworkmanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ken, Looks good

@kmaranionjc kmaranionjc merged commit bd50061 into master Feb 7, 2024
@jworkmanjc jworkmanjc mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADMU ADMU Module Release minor Minor Version Release
Development

Successfully merging this pull request may close these issues.

3 participants