-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sa 3041 retain default app protocol associations #105
Sa 3041 retain default app protocol associations #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few thoughts on functions tests and cleanup. Do we need the FtaPta Tests file? any reason to keep that whole commented out file in our repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup work here and all the changes. Approved, we'll do one more test before we publish the draft release but after testing migration one more time I can confirm that my default app settings were retained post-migration!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just finished testing on my end. Looks like the user's default apps are carrying over as expected. Nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ken, Looks good
Issues
What does this solve?
Is there anything particularly tricky?
Migrated user is unable to run unsigned uwp_jcadmu.exe unless the migrated user is an administrator.
How should this be tested?
FTA/PTA Test:
PRE-MIGRATION:
POST-MIGRATION
C:\Users\YOURUSER\Downloads\JCADMUBranch\Deploy
Invoke-ps2exe -inputFile .\uwp_jcadmu.ps1 -outputFile .\uwp_jcadmu.exe -title 'JumpCloud ADMU' -product 'JumpCloud ADMU' -description 'JumpCloud AD Migration Utility' -copyright "(c) $year" -version “2.6.0” -company 'JumpCloud' -requireAdmin -iconfile '.\admu.ico'
uwp_jcadmu.exe
move it toC:\Windows
uwp_jcadmu.exe
due to it being unsigned. My workaround testing until we get a signed file is to set the migrated user as an admin for the file to run properly.Load Hive Bug Test:
Set-UserRegistryLoadState
function