Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2.7.8 — Add system details to log and prevent overall failures if the leave domain step fails #144

Merged
merged 2 commits into from
Oct 14, 2024
Merged

V2.7.8 — Add system details to log and prevent overall failures if the leave domain step fails #144

merged 2 commits into from
Oct 14, 2024

Conversation

jworkmanjc
Copy link
Contributor

@jworkmanjc jworkmanjc commented Oct 14, 2024 •
edited by jira bot
Loading

Issues

  • CUT-4310 - CUT-4310 Add Windows OS Version info to Log
  • CUT-4354 - Leave Domain failure should not affect overall migration status

What does this solve?

  • Add Windows OS version information to jcAdmu.log
  • When the leave domain step failed, the ADMU would consider this a failure of the entire migration and attempt to revert the newly create local user. However at this stage of migration, if that occurred, the account being migrated was removed. This release addresses this issue by removing the failure status when the "leave domain" step is not successful.

Is there anything particularly tricky?

n/a

How should this be tested?

  1. Run this version of ADMU
  2. Migrate a user
  3. View Log and check that Windows OS Version info is in the log

image

@jworkmanjc jworkmanjc added ADMU ADMU Module Release patch Patch version release labels Oct 14, 2024
@jworkmanjc jworkmanjc requested a review from a team as a code owner October 14, 2024 19:11
kmaranionjc
kmaranionjc approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@kmaranionjc kmaranionjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tests worked on my end.

@jworkmanjc jworkmanjc merged commit 34a8fb5 into master Oct 14, 2024
9 checks passed
@jworkmanjc jworkmanjc temporarily deployed to PublishToPSGallery October 14, 2024 21:02 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gweinjc gweinjc gweinjc approved these changes

@kmaranionjc kmaranionjc kmaranionjc approved these changes

Assignees
No one assigned
Labels
ADMU ADMU Module Release patch Patch version release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jworkmanjc @gweinjc @kmaranionjc