Break up private functions & search menu bugfix #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmaranionjc
requested changes
Jan 28, 2025
jumpcloud-ADMU/Powershell/Tests/manualTests/selectionForm.feature
Outdated
Show resolved
Hide resolved
| Given The selection form is opened | ||
| And a domain (local AD or EntraID) user has logged into the device | ||
| When a domain profile is selected | ||
| And a JumpCloud username text "" is specified in the text box |
There was a problem hiding this comment.
Suggested change
| And a JumpCloud username text "" is specified in the text box | |
| And a null/blank JumpCloud username in the text box |
kmaranionjc
reviewed
Jan 29, 2025
jumpcloud-ADMU/Powershell/Tests/manualTests/progressForm.feature
Outdated
Show resolved
Hide resolved
kmaranionjc
reviewed
Jan 29, 2025
kmaranionjc
reviewed
Jan 29, 2025
should be resolved in [cc8907b](https://github.com/TheJumpCloud/jumpcloud-ADMU/commit/cc8907b0d1117e046be500fad11c6c48c98f171a)
|
kmaranionjc
approved these changes
Jan 29, 2025
gweinjc
approved these changes
Jan 29, 2025
jworkmanjc
added a commit
that referenced
this pull request
Jan 30, 2025
* Break up private functions & search menu bugfix (#152) * copied functions into new directory * Move Start Migration * remove functions from start-migration * move form * Changes for Form * move progress form * process by owner changes * progress forms changes * Assets file for forms * Get-ImageFromB64 * Function Names * rename Build-Exe * 2.7.11 version + build module functions * change patch for new-admuTemplate * pester tests * CI changes for functions location * functions tests * update several variable names in test /ci * paths for tests * update Build tests * Update VS Settings * paths for tests * Get-SID replace * migration tests paths * migration tests paths * remove start-jcadmu.ps1 file * escape $pid * write out log content * skip tests and validate log location in build runner * not tail log lines * Write-ToLog shouldn't terminate when writing an error * order in error messages * skip functions tests + why are we using silentlyContinue? * can't skip functions tests * write-error should be write-warnings until final throw message * tail and validate local users * version of artifact action * add param to build [skip ci] * write out additional debugging * CUT-4541 - reinstall search/ start appx for all devices (not just windows 10) * fixed migration tests by importing the module instead of calling start migration (which no longer contains any private functions) * variable names and logging changes * set systemKey in migration tests * Variable names * form elements, update to xaml form for MTP selection * manual tests for uwp + selection form * mtp selection form background + size * form changes for selecting another MTP org, manual tests * Form changes, test-button function updated to test various cases in helper functions * automate tests for selection form Test-MigrationButton * test the selection form in ci * mock names * Only show option to change ORG is MTP admin is returned * CUT-4589 Test for selection form on non-valid SID users * change placeholder text in progress form * update form to declare form elements before submission * Add focus controls to prevent checking the name each time a character is pressed (team to discuss) * CUT-4589 Test-LocalUsername fix * resolve changes with Get-MtpOrganization tests * skip migration tests * manual tests + changes to form, no default password * updates for local-username tests * test local username changes * build date * update start-migration for Get-MtpOrganization changes * Update form changes/ test-localUsername * remove throw in Test-LocalUserName, some devices might not have a user profile to validate like CI * variable name * update test-localUsernames after user is created * temp password should show valid when first viewing the selection form * incorrectly defined manual test * show error for username matching hostname * space in mtp selection * comment out tests mocking for CI
jworkmanjc
added a commit
that referenced
this pull request
Jan 30, 2025
* Break up private functions & search menu bugfix (#152) * copied functions into new directory * Move Start Migration * remove functions from start-migration * move form * Changes for Form * move progress form * process by owner changes * progress forms changes * Assets file for forms * Get-ImageFromB64 * Function Names * rename Build-Exe * 2.7.11 version + build module functions * change patch for new-admuTemplate * pester tests * CI changes for functions location * functions tests * update several variable names in test /ci * paths for tests * update Build tests * Update VS Settings * paths for tests * Get-SID replace * migration tests paths * migration tests paths * remove start-jcadmu.ps1 file * escape $pid * write out log content * skip tests and validate log location in build runner * not tail log lines * Write-ToLog shouldn't terminate when writing an error * order in error messages * skip functions tests + why are we using silentlyContinue? * can't skip functions tests * write-error should be write-warnings until final throw message * tail and validate local users * version of artifact action * add param to build [skip ci] * write out additional debugging * CUT-4541 - reinstall search/ start appx for all devices (not just windows 10) * fixed migration tests by importing the module instead of calling start migration (which no longer contains any private functions) * variable names and logging changes * set systemKey in migration tests * Variable names * form elements, update to xaml form for MTP selection * manual tests for uwp + selection form * mtp selection form background + size * form changes for selecting another MTP org, manual tests * Form changes, test-button function updated to test various cases in helper functions * automate tests for selection form Test-MigrationButton * test the selection form in ci * mock names * Only show option to change ORG is MTP admin is returned * CUT-4589 Test for selection form on non-valid SID users * change placeholder text in progress form * update form to declare form elements before submission * Add focus controls to prevent checking the name each time a character is pressed (team to discuss) * CUT-4589 Test-LocalUsername fix * resolve changes with Get-MtpOrganization tests * skip migration tests * manual tests + changes to form, no default password * updates for local-username tests * test local username changes * build date * update start-migration for Get-MtpOrganization changes * Update form changes/ test-localUsername * remove throw in Test-LocalUserName, some devices might not have a user profile to validate like CI * variable name * update test-localUsernames after user is created * temp password should show valid when first viewing the selection form * incorrectly defined manual test * show error for username matching hostname * space in mtp selection * comment out tests mocking for CI * update build to run in PS5.1 environments * build admu exe on windows hosts only * 5.1 build exe on windows hosts * update build tests now that we've moved the locations of all the function files * release from PSD1 version if manual release * re-validate exe file versions * Test exe in build tests * use artifact files for exe tests * exe location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
What does this solve?
build.ps1Is there anything particularly tricky?
How should this be tested?
Additional tests have been written to validate the changes to the selection form. There are three manual test files to check in this release. A number of items have changed in this release we need to validate those changes with the manual test files:
Screenshots