Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for radius membership #647

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Tests for radius membership #647

merged 6 commits into from
Feb 4, 2025

Conversation

jworkmanjc
Copy link
Contributor

@jworkmanjc jworkmanjc commented Jan 31, 2025 •
edited
Loading

Issues

What does this solve?

  • If large numbers of certificates are stored in the user certificates directory this update to the module will parse only the certificates that match usernames of the users in the defined radius group.
  • BugFix for cases where a user was in the radius member group but their cert could not be identified if they were the first user in the group.
  • Update tests to expand expected behavior

Is there anything particularly tricky?

How should this be tested?

Automated tests cover these changes

Screenshots

@jworkmanjc jworkmanjc marked this pull request as ready for review January 31, 2025 22:38
@jworkmanjc jworkmanjc requested a review from a team as a code owner January 31, 2025 22:38
kmaranionjc
kmaranionjc approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@kmaranionjc kmaranionjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bug fix! Looks good to me

@gweinjc gweinjc self-requested a review February 3, 2025 22:12
@jworkmanjc jworkmanjc merged commit b5c8bfa into Radius_2.0.0 Feb 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gweinjc gweinjc gweinjc approved these changes

@kmaranionjc kmaranionjc kmaranionjc approved these changes

Assignees
No one assigned
Labels
patch Radius Module
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jworkmanjc @gweinjc @kmaranionjc