Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUT-4602: Multi-Group Radius Report Function #655

Merged
merged 8 commits into from
Feb 26, 2025

Conversation

gweinjc
Copy link
Contributor

@gweinjc gweinjc commented Feb 21, 2025

Issues

  • CUT-4602 - Multi-Group Radius Report Function

What does this solve?

Created a new function to generate a report that accepts multiple groupIDs and will output a report that contains the following properties:
username
userid
systemHostname
systemID
systemOS
CertSerialNumber
CertExpirationDate
CertInstalled

Is there anything particularly tricky?

The function will need to be added to the end of the MultiGroup RADIUS script in order to function correctly

How should this be tested?

Without the MultiGroup Radius Script

  1. Import the RADIUS module
    a. NOTE: You may have to force update the global variables to ensure that the hashes are populated, it is also recommended to have at least a few certs deployed
  2. Run the following function:
Get-JCRCertReport -UserGroupIDs "usergroupid1" -ExportFilePath '/Users/USERNAME/RadiusReport.csv

With the MultiGroup Radius Script

  1. Copy the function to the end of the multiGroupRadius script
  2. Call the function similar to the first example except inputting the various userGroupIDs that were used
Get-JCRCertReport -UserGroupIDs "usergroupid1" -ExportFilePath '/Users/USERNAME/RadiusReport.csv

@gweinjc gweinjc requested a review from a team as a code owner February 21, 2025 21:07
@gweinjc gweinjc added the minor minor version release label Feb 25, 2025
})]
[System.IO.FileInfo]$ExportFilePath
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm going to be nitpicky, I'd say there really should be begin/ process/ end blocks here. I don't have anything else to add to the function

It "Generates the Report" {
# Export the report
Get-JCRCertReport -ExportFilePath "$JCScriptRoot/testReport.csv"
$report = Import-Csv -Path "$JCScriptRoot/testReport.csv"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for adding that here

Copy link
Contributor

@kmaranionjc kmaranionjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work here. Works on my end, code looks good

@gweinjc gweinjc merged commit 5a77e6e into Radius_2.0.0 Feb 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor minor version release Radius Module
Development

Successfully merging this pull request may close these issues.

3 participants