Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RUNTIME_DESTINATION variable #45

Merged
merged 6 commits into from
Dec 22, 2024
Merged

Conversation

dilshodm
Copy link
Contributor

Currently libs are installed under <...>/lib/<packagename-version>/ directory.

As a user I want to be able to configure relative subdirectory, similar to INCLUDE_DESTINATION.

For example, I want to install mylib.so as /usr/lib/mylib.so instead of /usr/lib/mylib-1.0/mylib.so. In this case I have to set RUNTIME_DESTINATION "/" as relative path.

@dilshodm dilshodm force-pushed the master branch 4 times, most recently from 0b3f847 to 90f1943 Compare September 20, 2024 16:59
It's possible to put libraries and binaries directly to bin/ and lib/ (using RUNTIME_DESTINATION /) instead of bin/<name-version> and lib/<name-version>
Copy link
Owner

@TheLartians TheLartians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature and a test case! Looks great, just a small suggestion to keep the CI script steps more organised.

dilshodm and others added 2 commits December 22, 2024 16:49
Refactor: move test to it's own step

Co-authored-by: Lars Melchior <TheLartians@users.noreply.github.com>
Copy link
Owner

@TheLartians TheLartians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@TheLartians TheLartians merged commit 738d2ed into TheLartians:master Dec 22, 2024
3 checks passed
@TheLartians
Copy link
Owner

Feature released in v1.13.0! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants