-
Notifications
You must be signed in to change notification settings - Fork 15.6k
Intermediate HTML/CSS: Gives Better Explaination for min and max #30255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Intermediate HTML/CSS: Gives Better Explaination for min and max #30255
Conversation
|
@Ansh-Kathil as per our general contributing guide, please wait until you have actually been assigned by a maintainer before opening a PR for an open issue. I will wait a little longer for the issue author to respond as it has not been that long since my message, and they may have simply missed the original assignment notification. If they are inactive after some further time, then I'll reassign and review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks - just a couple of changes detailed below, mainly to wording flow.
intermediate_html_css/intermediate_css_concepts/css_functions.md
Outdated
Show resolved
Hide resolved
intermediate_html_css/intermediate_css_concepts/css_functions.md
Outdated
Show resolved
Hide resolved
intermediate_html_css/intermediate_css_concepts/css_functions.md
Outdated
Show resolved
Hide resolved
Co-authored-by: mao-sz <122839503+mao-sz@users.noreply.github.com>
Co-authored-by: mao-sz <122839503+mao-sz@users.noreply.github.com>
|
Thanks for the clarification, the changes are ready for review. |
| ### max() | ||
|
|
||
| Consider the following property of a given element: | ||
| `max()` works the same way as `min()`, only in reverse, and is like JavaScript's `Math.max()` and Ruby's `Array#max` methods. It will select the largest possible value from within the parentheses. You can think of `max()` as ensuring a *minimum* allowed value for a property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I missed this in my previous comment about the whole max/min example thing. Once this has been removed, we should be good to merge.
| `max()` works the same way as `min()`, only in reverse, and is like JavaScript's `Math.max()` and Ruby's `Array#max` methods. It will select the largest possible value from within the parentheses. You can think of `max()` as ensuring a *minimum* allowed value for a property. | |
| `max()` works the same way as `min()`, only in reverse, and is like JavaScript's `Math.max()` and Ruby's `Array#max` methods. It will select the largest possible value from within the parentheses. |
Because
it Provided a better explanation for min and max function
This PR
Updated the section including min and max function
Issue
Closes #30020
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection