Skip to content

Conversation

Ansh-Kathil
Copy link

Because

it Provided a better explanation for min and max function

This PR

Updated the section including min and max function

Issue

Closes #30020

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course label Oct 17, 2025
@Ansh-Kathil Ansh-Kathil changed the title CSS Functions: Gives Better Explaination for min and max Intermediate HTML/CSS: Gives Better Explaination for min and max Oct 17, 2025
@mao-sz mao-sz added the Status: Do Not Merge This PR should not be merged until further notice label Oct 18, 2025
@mao-sz
Copy link
Contributor

mao-sz commented Oct 18, 2025

@Ansh-Kathil as per our general contributing guide, please wait until you have actually been assigned by a maintainer before opening a PR for an open issue. I will wait a little longer for the issue author to respond as it has not been that long since my message, and they may have simply missed the original assignment notification.

If they are inactive after some further time, then I'll reassign and review this PR.

@mao-sz mao-sz self-requested a review October 20, 2025 19:51
@mao-sz mao-sz removed the Status: Do Not Merge This PR should not be merged until further notice label Oct 20, 2025
Copy link
Contributor

@mao-sz mao-sz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks - just a couple of changes detailed below, mainly to wording flow.

@Ansh-Kathil Ansh-Kathil requested a review from mao-sz October 21, 2025 07:20
@Ansh-Kathil
Copy link
Author

Thanks for the clarification, the changes are ready for review.

### max()

Consider the following property of a given element:
`max()` works the same way as `min()`, only in reverse, and is like JavaScript's `Math.max()` and Ruby's `Array#max` methods. It will select the largest possible value from within the parentheses. You can think of `max()` as ensuring a *minimum* allowed value for a property.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I missed this in my previous comment about the whole max/min example thing. Once this has been removed, we should be good to merge.

Suggested change
`max()` works the same way as `min()`, only in reverse, and is like JavaScript's `Math.max()` and Ruby's `Array#max` methods. It will select the largest possible value from within the parentheses. You can think of `max()` as ensuring a *minimum* allowed value for a property.
`max()` works the same way as `min()`, only in reverse, and is like JavaScript's `Math.max()` and Ruby's `Array#max` methods. It will select the largest possible value from within the parentheses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS Functions: Better min() explanation

2 participants