Issue 84 - Change site-wide announcement into announcement with threa… #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nationwide13
requested changes
Apr 1, 2018
| if($fc->getId() == null || trim($fc->getId()) == "") | ||
| $em->persist($fc); | ||
| else | ||
| $em->merge($fc); |
There was a problem hiding this comment.
This can be changed to be bit cleaner/readable
// get existing
$fc = $fcr->findSitewide()
if (is_null($fc->getId()) || trim($fc->getId()) == "") {
// If not existing, create new one
$fc = $data->toForumConfiguration();
}
// Set the new data
$fc->setForumId(null);
$fc->setAnnouncementSubmissionId($submission->getId());
$em->persist($fc);
nationwide13
requested changes
Apr 1, 2018
|
|
||
| if ($form->isSubmitted() && $form->isValid()) { | ||
| $fc = $data->toForumConfiguration(); | ||
| // Find the user and forum for submission. | ||
| $user = $ur->loadUserByUsername($this->get('security.token_storage')->getToken()->getUser()->getUsername()); |
There was a problem hiding this comment.
This should be able to be simplified to $this->getUser()->getUsername();
There was a problem hiding this comment.
Oh ok, I looked around on SO and saw this was the first example of getting the username. I'll change this.
| // For sitewide settings, we need to force this to null. | ||
| $fc->setForumId(null); | ||
| // Load the current announcement's row id. Sitewide announcemnts have null forum id. | ||
| $fc = $fcr->findSitewide(); |
There was a problem hiding this comment.
Is there ever a situation this could return null?
On first migration, before the first announcement has been made?
There was a problem hiding this comment.
Yes, the only reason this would ever be null is if the announcement forum hadn't been made yet (or deleted for whatever reason).
nationwide13
approved these changes
Apr 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #84
The sitewide announcement page has been made to act as a post submission page
Note: a forum with the name of "announcements" is required.
To test this issue:
To remove the global announcement header