Added 'raw' markdown and 'preview' views #19
Open
priyank-mishra-1 wants to merge 2 commits intoTheShiveshNetwork:mainfrom
Open
Added 'raw' markdown and 'preview' views #19priyank-mishra-1 wants to merge 2 commits intoTheShiveshNetwork:mainfrom
priyank-mishra-1 wants to merge 2 commits intoTheShiveshNetwork:mainfrom
Conversation
|
@priyank-mishra-1 is attempting to deploy a commit to the theshiveshnetwork's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Please review my PR. I have added an additional dependency for resizable panels. If you don't want additional dependencies then I can recreate it with vanilla js. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
|
I'm writing a sample code to explain factory pattern, refer this code: function MobileComponent() {
return (
/* component to return modal for mobile screens */
)
}
function DesktopComponent() {
return (
/* component to return for desktop screens */
/* write all your resizable component code */
)
}
export default function ResizableFactory({ }: Props) {
const [isRawMode, setIsRawMode] = useState(false);
/* handle all the logic here*/
if (isMobile) return (
<MobileComponent/>
)
return (
<DesktopComponent/>
)
}Create this as a new component and all the logic related to resizable components and other things will go inside the factory component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #18
Description-
Created a toggle button for Raw markdown code view.
Changes made in Raw markdown editor are reflected in preview. Raw view and Preview are opened side by side with resizing panels.
Additional Details-
Added additional dependency for resizing panels -
npm i react-resizable-panelsAcceptance Criteria