Merged
Conversation
joelamouche
reviewed
Sep 10, 2025
Contributor
joelamouche
left a comment
joelamouche
left a comment
There was a problem hiding this comment.
Just some comments about the readme file...
oscarwroche
force-pushed
the
backend_handlers
branch
from
46c888b to
8a66360
Compare
joelamouche
reviewed
Sep 11, 2025
Contributor
joelamouche
left a comment
joelamouche
left a comment
There was a problem hiding this comment.
It would be good to add a sjort readme to the backend.
Maybe a few lines about Presentation / Infrastructure / Application / Domain stack.
Also a few lines about the siwe auth logic and what needs to be signed by each call.
backend/src/infrastructure/services/ethereum_address_verification_service.rs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.