feat: add backend for distribution#139
Open
Chesblaw wants to merge 1 commit intoTheSoftwareDevGuild:mainfrom
Open
feat: add backend for distribution#139Chesblaw wants to merge 1 commit intoTheSoftwareDevGuild:mainfrom
Chesblaw wants to merge 1 commit intoTheSoftwareDevGuild:mainfrom
Conversation
joelamouche
requested changes
Nov 24, 2025
Contributor
joelamouche
left a comment
There was a problem hiding this comment.
Thanks for the submission @Chesblaw ! Overall looks great, even though I would need to dig deeper into the implementation details.
However, before I do that, I think that something wasn't clear when in the task description: the distribution id is know before registering it into our backend (and therefore you should generate it in our backend).
The flow goes this way:
- create list of users that should get batches
- distribute badges to user using (foundry) script: this is where the distribution id is created (and optionally registered onchain to avoid duplicate distribution)
- register distirbution in the backend for accountability
Thanks in advance!
Author
|
@joelamouche gotchu |
Contributor
|
@Chesblaw How's the task going? |
Contributor
|
Any progress on this @Chesblaw ? Would be a shame to throw away a great PR |
Author
|
Hey @joelamouche i'm sorry for the late i will update you within a few days. |
Contributor
|
Okay sounds good :) |
Collaborator
|
Any update mate @Chesblaw? |
Contributor
|
Hi @Chesblaw, any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Distributions Backend
This PR introduces a complete backend implementation for the Distributions system, enabling batch badge distributions, persistent storage, and retrieval endpoints.
✨ New Features
Batch Distribution Endpoint
Each user maintains an independent, on-chain ScoreProfile.
New REST endpoint::
Query Capabilities
Technical Implementation
Files Added
Files Modified
Backend router/handler to wire distribution endpoints
Usage Example
✅ Checklist