Merged
Conversation
oscarwroche
force-pushed
the
indexer_new
branch
3 times, most recently
from
f152412 to
be5cce7
Compare
oscarwroche
force-pushed
the
indexer_new
branch
5 times, most recently
from
5d31501 to
4671a70
Compare
oscarwroche
force-pushed
the
indexer_new
branch
from
4671a70 to
e063379
Compare
✨ add main file for service
oscarwroche
force-pushed
the
indexer_new
branch
from
e063379 to
7e629bc
Compare
oscarwroche
force-pushed
the
indexer_new
branch
from
075be6d to
42acf68
Compare
joelamouche
reviewed
Sep 30, 2025
Contributor
joelamouche
left a comment
joelamouche
left a comment
There was a problem hiding this comment.
A quick readme/md file would be nice. And renaming the service to blockchain-indexer would make it easier to understand for new contributors
| #[async_trait] | ||
| impl EthereumEventPollingService for AlloyEthereumEventPollingService { | ||
| async fn poll(&self) -> Result<Vec<EthereumEvent>, Box<dyn Error>> { | ||
| let rpc_url = "https://reth-ethereum.ithaca.xyz/rpc".parse()?; |
Contributor
There was a problem hiding this comment.
We should load rpc_url and chain id from env. Well here it looks like chain_id is not provided but comes from whatever rpc is provided
| // Create a filter to get all logs from the latest block. | ||
| let filter = Filter::new() | ||
| .from_block(latest_block) | ||
| .event("Transfer(from,to,value)"); |
Contributor
There was a problem hiding this comment.
So what's the plan for this? Shouldn't it be an input of the function?
Contributor
There was a problem hiding this comment.
Ha I see the whole logic here is specific to activity token minting.
So how do we support badge creation indexing in the future?
This was referenced Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.