feat(backend): ingest GitHub issues with idempotent upsert (#74)#90
feat(backend): ingest GitHub issues with idempotent upsert (#74)#90Cedarich wants to merge 13 commits intoTheSoftwareDevGuild:mainfrom
Conversation
oscarwroche
left a comment
There was a problem hiding this comment.
The API interaction needs to be handled in the infrastructure layer instead of the application layer. Please create a service trait in the domain layer and create an implementation in the infrastructure. The application side should have no direct references to infrastructure (Github API, Postgres, etc) concerns
|
@oscarwroche Please review again This refactor enforces clean architecture boundaries: application depends on the GithubApiService trait, while infrastructure provides the HTTP implementation. No direct reqwest or Postgres references remain in the application layer. |
There was a problem hiding this comment.
@Cedarich Looks great overall! Just a comment about removing the query! macro in the indexer
indexer/src/infrastructure/repositories/postgres_ethereum_event_repository.rs
Outdated
Show resolved
Hide resolved
|
…hub.com/Cedarich/TheGuildGenesis into feat/backend-github-issues-ingestion-74
backend/src/infrastructure/repositories/postgres_github_issue_repository.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I still don't know why there are changes to the indexer files, they don't have anything to do with the goal of this PR. Creating this migration is unnecessary
There was a problem hiding this comment.
why is the migration renamed ?
There was a problem hiding this comment.
And I still don't understand why there are any changes to the indexer files
There was a problem hiding this comment.
why is the migration renamed ?
There was a problem hiding this comment.
And I still don't understand why there are any changes to the indexer files
|
@Cedarich what's the update on this pls? |
|
close due to inactivity |
🚀 PR: Ingest GitHub Issues into Backend Database (#74)
📌 Summary
🔍 Scope
POST /admin/github/sync{ "repos": ["org/repo", ...], "since": "2024-01-01T00:00:00Z" // optional }close #74