Skip to content

Add GitHub handle support#95

Merged
oscarwroche merged 25 commits intoTheSoftwareDevGuild:mainfrom
rainwaters11:feat/github-handle
Oct 5, 2025
Merged

Add GitHub handle support#95
oscarwroche merged 25 commits intoTheSoftwareDevGuild:mainfrom
rainwaters11:feat/github-handle

Conversation

@rainwaters11
Copy link

@rainwaters11 rainwaters11 commented Oct 5, 2025

Add GitHub Handle Support for Profiles

Summary

This pull request adds GitHub handle integration to user profiles, featuring validation, case-insensitive uniqueness, and robust CI/CD reliability. A new github_login column has been introduced to the profiles table. The update enforces GitHub username formatting rules and refreshes API endpoints to support querying, creating, and updating profiles by handle.

All migrations, tests, and workflows have been aligned for stable and repeatable CI runs. SQLx metadata is now properly cached, migrations execute before tests, and both backend workflows (ci.yml and test.yml) are synchronized.


Key Updates

  • Database

    • Added github_login column with unique lowercase index
    • Case-insensitive validation for duplicate handles
  • Testing

    • Added unit and integration tests for handle creation, updates, and queries
  • CI/CD

    • Postgres health check before running tests
    • Database migration resets before test execution
    • Verified .sqlx cache usage for SQLx metadata
    • Synchronized ci.yml and test.yml workflows
  • Code Quality

    • All Clippy warnings resolved
    • Rustfmt applied to entire codebase
  • Reliability

    • Both CI pipelines are now passing

Checklist

  • Migration tested locally
  • All tests passing
  • CI/CD verified
  • Code formatted and linted
  • Database structure validated

Status:
✅ All CI checks passing.
🚀 Ready for final review and merge.


Reviewer: Please verify all changes, especially the new validation logic and database migration.
For more details, see the code at TheSoftwareDevGuild/TheGuildGenesis.

Copy link
Collaborator

@oscarwroche oscarwroche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great overall! could you please remove some comments as well as the pr description file - also the tests aren't passing but seems like you're working on it :)

also it seems like i have to approve the CI for it to run, not sure where it comes from (and if it comes from this PR) - it would be better without this behavior

@rainwaters11
Copy link
Author

rainwaters11 commented Oct 5, 2025 via email

@oscarwroche
Copy link
Collaborator

I’m happy to report that both of the CI issues have been resolved: The backend Rust tests now pass consistently, with migrations applied and the profiles table present. The CI #140 workflow no longer fails with "relation 'profiles' does not exist". Thank you for your patience. At this point, the PR is stable and ready for your review & merge when convenient. Let me know if you’d like me to squash commits, rebase, or adjust any part of the PR before merging.

On Sun, Oct 5, 2025 at 2:59 AM Oscar Roche @.> wrote: @.* requested changes on this pull request. ------------------------------ On backend/migrations/003_create_profiles_table.sql <#95 (comment)> : there's already a migration that creates this table (number 1) — Reply to this email directly, view it on GitHub <#95 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6HDJ4CQTHLEIMU3HKXRYPD3WDFV3AVCNFSM6AAAAACIKBA5I2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMBSGI2TGMZWGU . You are receiving this because you authored the thread.Message ID: @.***>

Hi @rainwaters11 there is still an issue (as mentioned above) with the third migration that shouldn't be required

@rainwaters11
Copy link
Author

rainwaters11 commented Oct 5, 2025 via email

Copy link
Collaborator

@oscarwroche oscarwroche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for your contribution :)

@oscarwroche oscarwroche merged commit fc2163b into TheSoftwareDevGuild:main Oct 5, 2025
4 checks passed
@rainwaters11
Copy link
Author

rainwaters11 commented Oct 6, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments