Add GitHub handle support#95
Conversation
There was a problem hiding this comment.
looks great overall! could you please remove some comments as well as the pr description file - also the tests aren't passing but seems like you're working on it :)
also it seems like i have to approve the CI for it to run, not sure where it comes from (and if it comes from this PR) - it would be better without this behavior
|
I’m happy to report that both of the CI issues have been resolved:
The backend Rust tests now pass consistently, with migrations applied and
the profiles table present.
The CI #140 workflow no longer fails with "relation 'profiles' does not
exist".
Thank you for your patience. At this point, the PR is stable and ready for
your review & merge when convenient.
Let me know if you’d like me to squash commits, rebase, or adjust any part
of the PR before merging.
…On Sun, Oct 5, 2025 at 2:59 AM Oscar Roche ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
On backend/migrations/003_create_profiles_table.sql
<#95 (comment)>
:
there's already a migration that creates this table (number 1)
—
Reply to this email directly, view it on GitHub
<#95 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6HDJ4CQTHLEIMU3HKXRYPD3WDFV3AVCNFSM6AAAAACIKBA5I2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMBSGI2TGMZWGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Hi @rainwaters11 there is still an issue (as mentioned above) with the third migration that shouldn't be required |
|
I double checked it - made the changes and pushed. Thanks.
…On Sun, Oct 5, 2025 at 8:09 AM Misty Waters ***@***.***> wrote:
Can you please clarify? Because I removed that migration.
On Sun, Oct 5, 2025 at 8:00 AM Oscar Roche ***@***.***>
wrote:
> *oscarwroche* left a comment (TheSoftwareDevGuild/TheGuildGenesis#95)
> <#95 (comment)>
>
> I’m happy to report that both of the CI issues have been resolved: The
> backend Rust tests now pass consistently, with migrations applied and the
> profiles table present. The CI #140 workflow no longer fails with "relation
> 'profiles' does not exist". Thank you for your patience. At this point, the
> PR is stable and ready for your review & merge when convenient. Let me know
> if you’d like me to squash commits, rebase, or adjust any part of the PR
> before merging.
> … <#m_9035279013654848766_m_-1142942858286635908_>
> On Sun, Oct 5, 2025 at 2:59 AM Oscar Roche *@*.*> wrote: @.** requested
> changes on this pull request. ------------------------------ On
> backend/migrations/003_create_profiles_table.sql <#95 (comment)
> <#95 (comment)>>
> : there's already a migration that creates this table (number 1) — Reply to
> this email directly, view it on GitHub <#95 (review)
> <#95 (review)>>,
> or unsubscribe
> https://github.com/notifications/unsubscribe-auth/A6HDJ4CQTHLEIMU3HKXRYPD3WDFV3AVCNFSM6AAAAACIKBA5I2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMBSGI2TGMZWGU
> . You are receiving this because you authored the thread.Message ID: *@*
> .***>
>
> Hi @rainwaters11 <https://github.com/rainwaters11> there is still an
> issue (as mentioned above) with the third migration that shouldn't be
> required
>
> —
> Reply to this email directly, view it on GitHub
> <#95 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A6HDJ4HHUKURBGODTZEKVWL3WEI7RAVCNFSM6AAAAACIKBA5I2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNRZGA2DEMRZGQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
oscarwroche
left a comment
There was a problem hiding this comment.
LGTM ! Thanks for your contribution :)
|
Awesome, thanks for the update! Could you please complete this on Only Dust
as well when you get a spare moment? Appreciate it!
…On Sun, Oct 5, 2025 at 10:01 AM Oscar Roche ***@***.***> wrote:
Merged #95
<#95> into
main.
—
Reply to this email directly, view it on GitHub
<#95 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6HDJ4AYALLVCFIIRZFCFLD3WEXE3AVCNFSM6AAAAACIKBA5I2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRQGEYDCOBZHA3DSNI>
.
You are receiving this because you were mentioned.Message ID:
<TheSoftwareDevGuild/TheGuildGenesis/pull/95/issue_event/20101898695@
github.com>
|
Add GitHub Handle Support for Profiles
Summary
This pull request adds GitHub handle integration to user profiles, featuring validation, case-insensitive uniqueness, and robust CI/CD reliability. A new
github_logincolumn has been introduced to theprofilestable. The update enforces GitHub username formatting rules and refreshes API endpoints to support querying, creating, and updating profiles by handle.All migrations, tests, and workflows have been aligned for stable and repeatable CI runs. SQLx metadata is now properly cached, migrations execute before tests, and both backend workflows (
ci.ymlandtest.yml) are synchronized.Key Updates
Database
github_logincolumn with unique lowercase indexTesting
CI/CD
.sqlxcache usage for SQLx metadataci.ymlandtest.ymlworkflowsCode Quality
Reliability
Checklist
Status:
✅ All CI checks passing.
🚀 Ready for final review and merge.