Skip to content

Comments

feature: added a github handle to profile in frontend#99

Merged
joelamouche merged 7 commits intoTheSoftwareDevGuild:mainfrom
pheobeayo:fix-#98
Oct 9, 2025
Merged

feature: added a github handle to profile in frontend#99
joelamouche merged 7 commits intoTheSoftwareDevGuild:mainfrom
pheobeayo:fix-#98

Conversation

@pheobeayo
Copy link
Collaborator

fixes #98

Copy link
Contributor

@joelamouche joelamouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
When I am opening the editing dialog the form should be prefiled with the profile information.
I left a couple of other comments

@pheobeayo pheobeayo requested a review from joelamouche October 7, 2025 09:18
@joelamouche
Copy link
Contributor

Screenshot 2025-10-07 at 14 07 50 I would like the edit form to be prefilled with the profile's information pls

@pheobeayo
Copy link
Collaborator Author

@joelamouche Kindly check it out now

@joelamouche
Copy link
Contributor

In the profile list view it works for name and description but the github handle is not injected.
In the profile view, it doesn't get prefilled because ProfileActions doesn't get the props injected.
Btw it would be a good idea to at least make name and description required props to avoid this kind of confusion

@joelamouche
Copy link
Contributor

Okay so this won't work unfortunately, as explained in this comment #100 (comment) . The PR in question has a similar issue as you.
I suggested two possible fixes. Please coordinate with the other contributor on which solution is best. Whoever implements it first gets to decide ^^

@pheobeayo
Copy link
Collaborator Author

Okay so this won't work unfortunately, as explained in this comment #100 (comment) . The PR in question has a similar issue as you. I suggested two possible fixes. Please coordinate with the other contributor on which solution is best. Whoever implements it first gets to decide ^^

Okay

@pheobeayo
Copy link
Collaborator Author

@joelamouche I will have implemented what you suggested locally but the profile page of individuals comes out blank like this
image
any other suggestions?

@joelamouche
Copy link
Contributor

You should have an error in the console or the cli. But push your changes and I can try to fix it

@pheobeayo
Copy link
Collaborator Author

You should have an error in the console or the cli. But push your changes and I can try to fix it

Done

Copy link
Contributor

@joelamouche joelamouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@joelamouche joelamouche enabled auto-merge (rebase) October 9, 2025 12:11
@joelamouche joelamouche merged commit bb48f63 into TheSoftwareDevGuild:main Oct 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: add a github handle to profile in Front end

2 participants