Skip to content

bugfix(rendering): Fix the bugged Heat Haze (Smudge) effect of the USA Microwave Tank #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xezon wants to merge 8 commits into
base: main
Choose a base branch
from
Open

bugfix(rendering): Fix the bugged Heat Haze (Smudge) effect of the USA Microwave Tank #1073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a274319
[ZH] Fix the bugged smudge or heat haze effect of the USA Microwave Tank
xezon Jun 15, 2025
ac42ece
Fix clamping
xezon Oct 14, 2025
6b4dda7
Fix Y offset
xezon Oct 14, 2025
5b5f3d0
Fix static assert
xezon Oct 14, 2025
eca8668
Refactor uv value assignments
xezon Oct 14, 2025
bdb6551
Make copyRect function safer and add DX8Wrapper::Bytes_Per_Pixel func…
xezon Dec 21, 2025
377ea66
Simplify function W3DSmudgeManager::testHardwareSupport to what chat …
xezon Dec 21, 2025
4e86be2
render target texture copy test
xezon Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
273 changes: 97 additions & 176 deletions Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
{
SmudgeManager::init();
ReAcquireResources();
testHardwareSupport();
}

void W3DSmudgeManager::reset (void)
Expand All @@ -72,9 +73,12 @@
REF_PTR_RELEASE(m_indexBuffer);
}

//Make sure (SMUDGE_DRAW_SIZE * 12) < 65535 because that's the max index buffer size.

#define SMUDGE_DRAW_SIZE 500 //draw at most 50 smudges per call. Tweak value to improve CPU/GPU parallelism.

static_assert(SMUDGE_DRAW_SIZE * 5 < 0x10000, "Vertex index exceeds 16-bit limit");


void W3DSmudgeManager::ReAcquireResources(void)
{
ReleaseResources();
Expand Down Expand Up @@ -130,180 +134,73 @@
}
}

/*Copies a portion of the current render target into a specified buffer*/
Int copyRect(unsigned char *buf, Int bufSize, int oX, int oY, int width, int height)
{
IDirect3DSurface8 *surface=NULL; ///<previous render target
IDirect3DSurface8 *tempSurface=NULL;
Int result = 0;
HRESULT hr = S_OK;

LPDIRECT3DDEVICE8 m_pDev=DX8Wrapper::_Get_D3D_Device8();

if (!m_pDev)
goto error;

m_pDev->GetRenderTarget(&surface);

if (!surface)
goto error;

D3DSURFACE_DESC desc;

surface->GetDesc(&desc);

RECT srcRect;
srcRect.left=oX;
srcRect.top=oY;
srcRect.right=oX+width;
srcRect.bottom=oY+height;

POINT dstPoint;
dstPoint.x=0;
dstPoint.y=0;

hr=m_pDev->CreateImageSurface( width, height, desc.Format, &tempSurface);

if (hr != S_OK)
goto error;

hr=m_pDev->CopyRects(surface,&srcRect,1,tempSurface,&dstPoint);

if (hr != S_OK)
goto error;

D3DLOCKED_RECT lrect;

hr=tempSurface->LockRect(&lrect,NULL,D3DLOCK_READONLY);

if (hr != S_OK)
goto error;

tempSurface->GetDesc(&desc);

if (desc.Size < bufSize)
bufSize = desc.Size;

memcpy(buf,lrect.pBits,bufSize);
result = bufSize;

tempSurface->UnlockRect();

error:
if (surface)
surface->Release();
if (tempSurface)
tempSurface->Release();

return result;
}

#define UNIQUE_COLOR (0x12345678)
#define BLOCK_SIZE (8)

Bool W3DSmudgeManager::testHardwareSupport(void)
{
if (m_hardwareSupportStatus == SMUDGE_SUPPORT_UNKNOWN)
{ //we have not done the test yet.

IDirect3DTexture8 *backTexture=W3DShaderManager::getRenderTexture();
if (!backTexture)
{ //do trivial test first to see if render target exists.
m_hardwareSupportStatus = SMUDGE_SUPPORT_NO;
return FALSE;
}
// Return cached result if already checked
if (m_hardwareSupportStatus != SMUDGE_SUPPORT_UNKNOWN)
{
return m_hardwareSupportStatus == SMUDGE_SUPPORT_YES;
}

if (!W3DShaderManager::isRenderingToTexture())
return FALSE; //can't do the test unless we're rendering to texture.

VertexMaterialClass *vmat=VertexMaterialClass::Get_Preset(VertexMaterialClass::PRELIT_DIFFUSE);
DX8Wrapper::Set_Material(vmat);
REF_PTR_RELEASE(vmat); //no need to keep a reference since it's a preset.

ShaderClass shader=ShaderClass::_PresetOpaqueShader;
shader.Set_Depth_Compare(ShaderClass::PASS_ALWAYS);
shader.Set_Depth_Mask(ShaderClass::DEPTH_WRITE_DISABLE);
DX8Wrapper::Set_Shader(shader);
DX8Wrapper::Set_Texture(0,NULL);
DX8Wrapper::Apply_Render_State_Changes(); //force update of view and projection matrices

struct _TRANS_LIT_TEX_VERTEX {
Vector4 p;
DWORD color; // diffuse color
float u;
float v;
} v[4];

//bottom right
v[0].p = Vector4( BLOCK_SIZE-0.5f, BLOCK_SIZE-0.5f, 0.0f, 1.0f );
v[0].u = BLOCK_SIZE/(Real)TheDisplay->getWidth(); v[0].v = BLOCK_SIZE/(Real)TheDisplay->getHeight();
//top right
v[1].p = Vector4( BLOCK_SIZE-0.5f, 0-0.5f, 0.0f, 1.0f );
v[1].u = BLOCK_SIZE/(Real)TheDisplay->getWidth(); v[1].v = 0;
//bottom left
v[2].p = Vector4( 0-0.5f, BLOCK_SIZE-0.5f, 0.0f, 1.0f );
v[2].u = 0; v[2].v = BLOCK_SIZE/(Real)TheDisplay->getHeight();
//top left
v[3].p = Vector4( 0-0.5f, 0-0.5f, 0.0f, 1.0f );
v[3].u = 0; v[3].v = 0;

v[0].color = UNIQUE_COLOR;
v[1].color = UNIQUE_COLOR;
v[2].color = UNIQUE_COLOR;
v[3].color = UNIQUE_COLOR;

LPDIRECT3DDEVICE8 pDev=DX8Wrapper::_Get_D3D_Device8();

//draw polygons like this is very inefficient but for only 2 triangles, it's
//not worth bothering with index/vertex buffers.
pDev->SetVertexShader(D3DFVF_XYZRHW | D3DFVF_DIFFUSE | D3DFVF_TEX1);

pDev->DrawPrimitiveUP(D3DPT_TRIANGLESTRIP, 2, v, sizeof(_TRANS_LIT_TEX_VERTEX));

DWORD refData[BLOCK_SIZE*BLOCK_SIZE];
memset(refData,0,sizeof(refData));
Int bufSize=copyRect((unsigned char *)refData,sizeof(refData),0,0,BLOCK_SIZE,BLOCK_SIZE); //copy area we just rendered using solid color
if (!bufSize)
{
m_hardwareSupportStatus = SMUDGE_SUPPORT_NO;
return FALSE;
}
LPDIRECT3DDEVICE8 d3d8Device = DX8Wrapper::_Get_D3D_Device8();
LPDIRECT3D8 d3d8Interface = DX8Wrapper::_Get_D3D8();
if (!d3d8Device || !d3d8Interface)
{
m_hardwareSupportStatus = SMUDGE_SUPPORT_NO;
return false;
}

DX8Wrapper::Set_DX8_Texture(0,backTexture);
D3DCAPS8 caps;
d3d8Device->GetDeviceCaps(&caps);

DWORD testData[BLOCK_SIZE*BLOCK_SIZE];
memset(testData,0xff,sizeof(testData));
// DX8 requires dynamic textures to efficiently update smudge texture
if (!(caps.Caps2 & D3DCAPS2_DYNAMICTEXTURES))
{
m_hardwareSupportStatus = SMUDGE_SUPPORT_NO;
return false;
}

v[0].color = 0xffffffff;
v[1].color = 0xffffffff;
v[2].color = 0xffffffff;
v[3].color = 0xffffffff;
IDirect3DTexture8 *backTexture = W3DShaderManager::getRenderTexture();
if (!backTexture)
{
m_hardwareSupportStatus = SMUDGE_SUPPORT_NO;
return FALSE;
}

pDev->DrawPrimitiveUP(D3DPT_TRIANGLESTRIP, 2, v, sizeof(_TRANS_LIT_TEX_VERTEX));
bufSize=copyRect((unsigned char *)testData,sizeof(testData),0,0,BLOCK_SIZE,BLOCK_SIZE);
IDirect3DSurface8* surface;
if (FAILED(backTexture->GetSurfaceLevel(0, &surface)))
{
m_hardwareSupportStatus = SMUDGE_SUPPORT_NO;
return false;
}

if (!bufSize)
{
m_hardwareSupportStatus = SMUDGE_SUPPORT_NO;
return FALSE;
}
D3DSURFACE_DESC desc;
surface->GetDesc(&desc);
surface->Release();

//compare the 2 buffers to see if they match.
if (memcmp(testData,refData,bufSize) == 0)
{
m_hardwareSupportStatus = SMUDGE_SUPPORT_YES;
return TRUE;
}
// Check if the device supports render-to-texture for this format
HRESULT hr = d3d8Interface->CheckDeviceFormat(
D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL,
DX8Wrapper::_Get_D3D_Back_Buffer_Format(),

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6-debug+t+e 

 '_Get_D3D_Back_Buffer_Format' : undeclared identifier

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6-debug+t+e 

 '_Get_D3D_Back_Buffer_Format' : is not a member of 'DX8Wrapper'

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / win32-debug+t+e 

 '_Get_D3D_Back_Buffer_Format': identifier not found

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / win32-debug+t+e 

 '_Get_D3D_Back_Buffer_Format': is not a member of 'DX8Wrapper'

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / win32+t+e 

 '_Get_D3D_Back_Buffer_Format': identifier not found

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / win32+t+e 

 '_Get_D3D_Back_Buffer_Format': is not a member of 'DX8Wrapper'

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6-profile+t+e 

 '_Get_D3D_Back_Buffer_Format' : undeclared identifier

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6-profile+t+e 

 '_Get_D3D_Back_Buffer_Format' : is not a member of 'DX8Wrapper'

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6+t+e 

 '_Get_D3D_Back_Buffer_Format' : undeclared identifier

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6+t+e 

 '_Get_D3D_Back_Buffer_Format' : is not a member of 'DX8Wrapper'

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / win32-profile+t+e 

 '_Get_D3D_Back_Buffer_Format': identifier not found

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / win32-profile+t+e 

 '_Get_D3D_Back_Buffer_Format': is not a member of 'DX8Wrapper'

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / win32-vcpkg-debug+t+e 

 '_Get_D3D_Back_Buffer_Format': identifier not found

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / win32-vcpkg-debug+t+e 

 '_Get_D3D_Back_Buffer_Format': is not a member of 'DX8Wrapper'

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / win32-vcpkg-profile+t+e 

 '_Get_D3D_Back_Buffer_Format': identifier not found

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / win32-vcpkg-profile+t+e 

 '_Get_D3D_Back_Buffer_Format': is not a member of 'DX8Wrapper'

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / win32-vcpkg+t+e 

 '_Get_D3D_Back_Buffer_Format': identifier not found

Check failure on line 184 in Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / win32-vcpkg+t+e 

 '_Get_D3D_Back_Buffer_Format': is not a member of 'DX8Wrapper'
D3DUSAGE_RENDERTARGET,
D3DRTYPE_TEXTURE,
desc.Format
);

if (hr != D3D_OK)
{
m_hardwareSupportStatus = SMUDGE_SUPPORT_NO;
return false;
}

return (SMUDGE_SUPPORT_YES == m_hardwareSupportStatus);
m_hardwareSupportStatus = SMUDGE_SUPPORT_YES;
return true;
}

void W3DSmudgeManager::render(RenderInfoClass &rinfo)
{
//Verify that the card supports the effect.
if (!testHardwareSupport())
if (m_hardwareSupportStatus == SMUDGE_SUPPORT_NO)
return;

CameraClass &camera=rinfo.Camera;
Expand Down Expand Up @@ -391,26 +288,16 @@
Vector2 &thisUV=verts[i].uv;

//Clamp coordinates so we're not referencing texels outside the view.
if (thisUV.X > texClampX)
smudge->m_offset.X = 0;
else
if (thisUV.X < 0)
smudge->m_offset.X = 0;

if (thisUV.Y > texClampY)
smudge->m_offset.Y = 0;
else
if (thisUV.Y < 0)
smudge->m_offset.Y = 0;

WWMath::Clamp(thisUV.X, 0, texClampX);
WWMath::Clamp(thisUV.Y, 0, texClampY);
}

//Finish center vertex
//Ge uv coordinates by interpolating corner uv coordinates and applying desired offset.
uvSpanX=verts[3].uv.X - verts[0].uv.X;
uvSpanY=verts[1].uv.Y - verts[0].uv.Y;
verts[4].uv.X=verts[0].uv.X+uvSpanX*(0.5f+smudge->m_offset.X);
verts[4].uv.Y=verts[0].uv.Y+uvSpanY*(0.5f+smudge->m_offset.X);
verts[4].uv.Y=verts[0].uv.Y+uvSpanY*(0.5f+smudge->m_offset.Y);

count++; //increment visible smudge count.
smudge=smudge->Succ();
Expand Down Expand Up @@ -450,7 +337,29 @@
#ifdef USE_COPY_RECTS
DX8Wrapper::Set_Texture(0,m_backgroundTexture);
#else
DX8Wrapper::Set_DX8_Texture(0,backTexture);

IDirect3DTexture8* renderTextureCopy = NULL;
DX8Wrapper::_Get_D3D_Device8()->CreateTexture(
D3DDesc.Width,
D3DDesc.Height,
1,
0,
D3DDesc.Format,
D3DPOOL_DEFAULT,
&renderTextureCopy);

IDirect3DSurface8* srcRT = nullptr;
IDirect3DSurface8* dstRT = nullptr;

backTexture->GetSurfaceLevel(0, &srcRT);
renderTextureCopy->GetSurfaceLevel(0, &dstRT);

DX8Wrapper::_Get_D3D_Device8()->CopyRects(srcRT, nullptr, 0, dstRT, nullptr);

srcRT->Release();
dstRT->Release();

DX8Wrapper::Set_DX8_Texture(0,renderTextureCopy);
//Need these states in case texture is non-power-of-2
DX8Wrapper::Set_DX8_Texture_Stage_State( 0, D3DTSS_ADDRESSU, D3DTADDRESS_CLAMP);
DX8Wrapper::Set_DX8_Texture_Stage_State( 0, D3DTSS_ADDRESSV, D3DTADDRESS_CLAMP);
Expand All @@ -462,12 +371,12 @@
VertexMaterialClass *vmat=VertexMaterialClass::Get_Preset(VertexMaterialClass::PRELIT_DIFFUSE);
DX8Wrapper::Set_Material(vmat);
REF_PTR_RELEASE(vmat);
DX8Wrapper::Apply_Render_State_Changes();

//Disable reading texture alpha since it's undefined.
//DX8Wrapper::Set_DX8_Texture_Stage_State(0,D3DTSS_COLOROP,D3DTOP_SELECTARG1);
DX8Wrapper::Set_DX8_Texture_Stage_State(0,D3DTSS_ALPHAOP,D3DTOP_SELECTARG2);

Int smudgesBatchCount=0;
Int smudgesRemaining=count;
set=m_usedSmudgeSetList.Head(); //first smudge set that needs rendering.
Smudge *remainingSmudgeStart=set->getUsedSmudgeList().Head(); //first smudge that needs rendering.
Expand Down Expand Up @@ -497,7 +406,8 @@

//Check if we exceeded maximum number of smudges allowed per draw call.
if (smudgesInRenderBatch >= count)
{ remainingSmudgeStart = smudge;
{
remainingSmudgeStart = smudge;
goto flushSmudges;
}

Expand Down Expand Up @@ -530,9 +440,10 @@
if (set) //start next batch at beginning of set.
remainingSmudgeStart = set->getUsedSmudgeList().Head();
}
flushSmudges:
DX8Wrapper::Set_Vertex_Buffer(vb_access);
}
flushSmudges:
++smudgesBatchCount;
DX8Wrapper::Set_Vertex_Buffer(vb_access);

DX8Wrapper::Draw_Triangles( 0,smudgesInRenderBatch*4, 0, smudgesInRenderBatch*5);

Expand All @@ -548,7 +459,17 @@
smudgesRemaining -= smudgesInRenderBatch;
}

// TheSuperHackers @bugfix xezon 15/06/2025 Draw a dummy point with the last vertex buffer
// to force the GPU to flush all current pipeline state and commit the previous draw call.
// This is required for some AMD models and drivers that refuse to flush a single draw call
// for the smudges. This draw call is invisible and harmless.
//if (smudgesBatchCount == 1)
//{
// DX8Wrapper::_Get_D3D_Device8()->DrawPrimitive(D3DPT_POINTLIST, 0, 1);
//}

DX8Wrapper::Set_DX8_Texture_Stage_State(0,D3DTSS_COLOROP,D3DTOP_MODULATE);
DX8Wrapper::Set_DX8_Texture_Stage_State(0,D3DTSS_ALPHAOP,D3DTOP_MODULATE);

renderTextureCopy->Release();
}
Loading
Loading