Skip to content

Fix use-after-free crash when replay ends in headless mode in debug build #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobtista wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

Fix use-after-free crash when replay ends in headless mode in debug build #2219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/Common/Recorder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,15 @@ void RecorderClass::stopPlayback() {

if (!m_doingAnalysis)
{
// TheSuperHackers @bugfix bobtista 29/01/2026 In headless mode, exit directly to avoid
// use-after-free crash during normal game cleanup. The crash occurs because objects are
// accessed after being freed during TheGameEngine->reset(). Since headless mode has no UI
// and is about to exit anyway, we can safely skip the cleanup and let the OS reclaim resources.
if (TheGlobalData->m_headless)
{
exit(0);
}

TheGameLogic->exitGame();
}
}
Expand Down
Loading