Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reversed Join Server dev nonce metrics #7337

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

ryaplots
Copy link
Contributor

Summary

References #7318

Changes

  • Reverse metrics

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the c/join server This is related to the Join Server label Oct 10, 2024
@ryaplots ryaplots added this to the v3.32.2 milestone Oct 10, 2024
@ryaplots ryaplots self-assigned this Oct 10, 2024
@ryaplots ryaplots requested a review from a team as a code owner October 10, 2024 08:40
@ryaplots ryaplots merged commit 4203826 into v3.32 Oct 15, 2024
12 of 13 checks passed
@ryaplots ryaplots deleted the fix/dev-nonces-reuse-too-small branch October 15, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/join server This is related to the Join Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants