Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page limit tests to search requests #7386

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

ryaplots
Copy link
Contributor

Summary

References https://thethingsindustries.slack.com/archives/C06UQSMPB/p1730378188247159

Changes

  • Add page limit tests to entity search requests

Testing

Steps

Running tests

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added this to the v3.33.0 milestone Nov 18, 2024
@ryaplots ryaplots self-assigned this Nov 18, 2024
@github-actions github-actions bot added the c/identity server This is related to the Identity Server label Nov 18, 2024
@ryaplots ryaplots force-pushed the fix/page-limit-tests branch from 9457ed1 to 6368bef Compare November 18, 2024 10:49
@github-actions github-actions bot added the compat/db This could affect Database compatibility label Nov 19, 2024
@ryaplots ryaplots force-pushed the fix/page-limit-tests branch from 2e87af1 to 3684fc6 Compare November 19, 2024 10:38
@ryaplots ryaplots marked this pull request as ready for review November 19, 2024 10:39
@ryaplots ryaplots requested a review from a team as a code owner November 19, 2024 10:39
@ryaplots ryaplots requested a review from nicholaspcr November 19, 2024 10:39
Copy link
Contributor

@nicholaspcr nicholaspcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

A small nit is that it would be more interesting to have only 9 instead of 15 simply to have the second page of the <entity_type>_PageLimit tests not be maximum value.

Meaning that under the default value the first page would contain 7 items but the second page would have less (2 items)

@ryaplots ryaplots merged commit 695d8e7 into v3.33 Nov 21, 2024
11 of 13 checks passed
@ryaplots ryaplots deleted the fix/page-limit-tests branch November 21, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/identity server This is related to the Identity Server compat/db This could affect Database compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants