Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user email notification preferences feature (merge feature branch into version branch) #7394

Merged
merged 36 commits into from
Nov 25, 2024

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Nov 19, 2024

Summary

References #7308

This PR is a merger of BE and FE parts of the feature.

Testing

Steps
  1. log in as admin into the console
  2. select a notification types you want to receive email for
  3. Then trigger sending some notifications. If the email notification type is selected the user should receive an email for that, if it is unselected the user should not receive an email.

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added c/console This is related to the Console c/identity server This is related to the Identity Server compat/db This could affect Database compatibility ui/web This is related to a web interface labels Nov 19, 2024
@ryaplots ryaplots added this to the v3.33.0 milestone Nov 19, 2024
@ryaplots ryaplots self-assigned this Nov 19, 2024
@ryaplots ryaplots marked this pull request as ready for review November 19, 2024 13:17
@ryaplots ryaplots requested review from a team as code owners November 19, 2024 13:17
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@nicholaspcr nicholaspcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryaplots ryaplots force-pushed the feature/user-notification-preferences branch from aac0019 to b9935cc Compare November 25, 2024 13:58
@ryaplots ryaplots merged commit 12cf46b into v3.33 Nov 25, 2024
15 of 16 checks passed
@ryaplots ryaplots deleted the feature/user-notification-preferences branch November 25, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console c/identity server This is related to the Identity Server compat/db This could affect Database compatibility ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants