Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RelayNotifyNewEndDeviceReq fields order #7440

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

halimi
Copy link
Contributor

@halimi halimi commented Dec 10, 2024

Summary

References: #7334

In the RelayNotifyNewEndDeviceReq MAC command, the fields were swapped. It was PowerLevel | DevAddr instead of DevAddr | PowerLevel.

Changes

  • Swapped field order in RelayNotifyNewEndDeviceReq

Testing

Steps

...

Results
Regressions

...

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@halimi halimi requested a review from a team as a code owner December 10, 2024 16:56
@halimi halimi requested a review from johanstokking December 10, 2024 16:56
@halimi halimi self-assigned this Dec 10, 2024
@halimi halimi added this to the v3.33.1 milestone Dec 10, 2024
@halimi halimi merged commit 7ebe8d7 into v3.33 Dec 11, 2024
12 of 13 checks passed
@halimi halimi deleted the fix/7334-relay-payload-incorrectly-formatted branch December 11, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants