Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permission checks to every add action #7493

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Conversation

ryaplots
Copy link
Contributor

Summary

References https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1221#issuecomment-2615688751

This PR fixes rights checks for add actions in the console.

Changes

  • Add rights checks for all add actions

Testing

Steps

Test this with a support user or a user that cannot create any entity. There shouldn't be add buttons visible.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the ui/web This is related to a web interface label Jan 28, 2025
@ryaplots ryaplots added this to the v3.33.1 milestone Jan 28, 2025
@ryaplots ryaplots self-assigned this Jan 28, 2025
@ryaplots ryaplots requested a review from a team as a code owner January 28, 2025 12:45
@ryaplots ryaplots merged commit eeac6c6 into v3.34 Jan 28, 2025
12 of 13 checks passed
@ryaplots ryaplots deleted the fix/user-permissions branch January 28, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants