Refactor ns device registry validation #7495
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References: #7380
The
NsEndDeviceRegistryServer.Set()
function is more than 3k row long and it is hard to follow what it does. The biggest part is doing different kind of validations and this part can be split up and move out to different validator functions.Changes
NsEndDeviceRegistryServer.Set()
function validation part and move it out to validator functions.Testing
Steps
The code logic haven't changed just restructured. The unit tests should pass.
Results
Regressions
Notes for Reviewers
The code logic haven't changed just moved out some part of the code to validator functions. This change will make it easier to validate the mac setting profile.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.