Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LagBar not working on every spell + Lag Bar not properly updating. #4

Open
Toonic opened this issue Oct 24, 2024 · 3 comments
Open

Comments

@Toonic
Copy link
Contributor

Toonic commented Oct 24, 2024

I was messing around with it on my Warlock and I noticed that not every spell is working as expected. When I cast Incinerate, or Immolate, neither of the spells trigger the lag bar code.

To test this I modified the code in the PlayerCastLagBar function, and added a simple print("Hello") inside of the if playerSpell and VCBrPlayer["LagBar"] == "Show" then. And noticed that no debug message was printed on Incinerate or Immolate. However, casting any other spell would show the lag bar and the print.

@Toonic
Copy link
Contributor Author

Toonic commented Oct 24, 2024

Update: You'll want to change IsPlayerSpell to IsSpellKnownOrOverridesKnown the issue in my case is specifically due to the spell being overriden to the "Green Fire" Variant of a Warlock.

@Toonic Toonic changed the title LagBar not working on every spell. LagBar not working on every spell + Lag Bar not properly updating. Oct 24, 2024
@Toonic
Copy link
Contributor Author

Toonic commented Oct 24, 2024

Additional bug as well: The lag bar value isn't updating properly. Specifically, if you cast one spell, and queue up a second spell (Or even just spam the spell cast button during the cast.) the bars latency will never change.

I'm unsure of the root cause of this currently. But its something that I've noticed.

EDIT: This seems to be normal behavior. I've tested a few different addons. (Quartz, Weakauras, etc.) And all have the same behavior.

TheTrueIndolent added a commit that referenced this issue Oct 26, 2024
Addressing Issues #3 and Issue #4
@TheTrueIndolent
Copy link
Owner

The funny thing is if your print(lagTotal) you will see that the number is right, but the bar doesn't change!
And another funny think is if you run the /eventtrace in the game you will notice that it tracks your lag in some events like the event "UNIT_SPELLCAST_START" in milliseconds but the only way I could take the number is the way I use in the add on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants