Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing Issues #3 and Issue #4 #5

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

Toonic
Copy link
Contributor

@Toonic Toonic commented Oct 24, 2024

Addressing #3 and #4

  • Fixed spelling on World of Warcraft
  • Changed IsPlayerSpell to IsSpellKnownOrOverridesKnown
  • Added SpellQueueWindow to CastBar
  • Added SpellQueueWindow to ChannelBar
  • Renamed LagBars to PlayerCastLagBar and PlayerChannelLagBar
  • Added Border for better prettyness.

- Changed IsPlayerSpell to IsSpellKnownOrOverridesKnown
- Added SpellQueueWindow to CastBar
- Added SpellQueueWindow to ChannelBar
- Added Border for better prettyness.
@Toonic
Copy link
Contributor Author

Toonic commented Oct 24, 2024

As a note: I didn't add the options for this. You'd still need to do that. I'm not really sure how you have it set up.

@Toonic
Copy link
Contributor Author

Toonic commented Oct 25, 2024

Oh and also, two screenshots of it in action just for reference. Im not a fan of the color for channeling, thats up to you if you want to do a tick or a bar.

image
image

Copy link
Owner

@TheTrueIndolent TheTrueIndolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution!

@TheTrueIndolent TheTrueIndolent merged commit c1171d3 into TheTrueIndolent:main Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants