Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of ws ping pong #51

Merged
merged 4 commits into from
Apr 29, 2022
Merged

Initial implementation of ws ping pong #51

merged 4 commits into from
Apr 29, 2022

Conversation

gloveboxes
Copy link
Contributor

No description provided.

@Theldus Theldus self-requested a review April 29, 2022 02:09
@Theldus
Copy link
Owner

Theldus commented Apr 29, 2022 •
edited
Loading

Hi @gloveboxes,
Thank you so much for the PR and impl idea.
I'll review as we talked in #50 and add the changes we talked about earlier.

For the 'v2', I'll probably create a PR and mention you if you have any additional feedback.

@Theldus Theldus merged commit ed3c45c into Theldus:master Apr 29, 2022
@Theldus Theldus mentioned this pull request Apr 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Theldus Theldus Theldus approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gloveboxes @Theldus