Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): #39 update type declaration syntax #41

Closed
wants to merge 1 commit into from
Closed

feat(parser): #39 update type declaration syntax #41

wants to merge 1 commit into from

Conversation

miguelcsx
Copy link
Contributor

  • change type declaration syntax for better readability
    Here’s a commit message and PR description following the conventional commit format:

Description

This PR updates the syntax for type declarations to make it more intuitive and readable. Previously, types were declared using the format:

x<Function<Number, Number, Number>> = () -> ...

This has been changed to:

x: Function<Number, Number, Number> = () -> ...

The new format improves clarity by separating the variable from its type explicitly using a colon :.

Changes

  • Modified src/parser/Parser.cpp to support the new syntax for type declarations.

Motivation

  • Enhances readability of type declarations.
  • Makes the distinction between variables and types clearer.

Related Issues

#39

Missing Work

  • Update tests to reflect the new type declaration format.
  • Verify existing test cases still pass.

- change type declaration syntax for better readability
@alexdovzhanyn
Copy link
Collaborator

@miguelcsx Thanks for the PR! It looks like there are some failing tests relating to the parsing change, so there's more work to be done here

@alexdovzhanyn
Copy link
Collaborator

Also for what its worth, issue #39 is currently being worked on by @ohmschrodinger. If you'd like to work on an issue, please leave a comment on the issue you would like to work on and I'll assign it to you.

@miguelcsx
Copy link
Contributor Author

@alexdovzhanyn My bad, I didn't see that it already had an assignment, I'm going to close the PR and the changes

@miguelcsx miguelcsx closed this Oct 2, 2024
@alexdovzhanyn
Copy link
Collaborator

@miguelcsx no worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants