Skip to content

Fix iOS redirection when scheme is https #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 7, 2024
Merged

Fix iOS redirection when scheme is https #117

merged 5 commits into from
Aug 7, 2024

Conversation

GabrielDamasceno
Copy link

@GabrielDamasceno GabrielDamasceno commented Aug 7, 2024 •
edited
Loading

Enable ASWebAuthenticationSession.Callback.https support to fix Universal Links on iOS.

Fixes #65
Fixes #104

@ThexXTURBOXx
Copy link
Owner

Thank you very much for your PR, it's very appreciated!
I have reverted some of the styling changes.
Actually, I had individual options (like you had proposed) in my mind in the past, but this will lead to very messy code - both in flutter_web_auth_2 and on the user's end.
This is why I ultimately did not go that route.
I do have a few more tiny things, though. One second.

ThexXTURBOXx
ThexXTURBOXx requested changes Aug 7, 2024
View reviewed changes
Copy link
Owner

@ThexXTURBOXx ThexXTURBOXx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And finally, after all of that, could you please check whether everything still compiles correctly and/or works correctly?
Thank you very much!

@ThexXTURBOXx
Copy link
Owner

The pipeline has passed, so everything seems to be in order now :)
Thank you very much for your contribution - will merge now and publish a new pre-release soon!

@ThexXTURBOXx ThexXTURBOXx merged commit 59424aa into ThexXTURBOXx:master Aug 7, 2024
2 checks passed
@GabrielDamasceno
Copy link
Author

Thank you for maintaining this plugin ;)

Best regards!

@ThexXTURBOXx ThexXTURBOXx mentioned this pull request Aug 8, 2024
Open
GabrielDamasceno added a commit to GabrielDamasceno/flutter_web_auth_2 that referenced this pull request Aug 20, 2024
@GabrielDamasceno @ThexXTURBOXx
Fix iOS redirection when scheme is https (ThexXTURBOXx#117)
7e80cbd 
* fix: fix ios redirects

* feat: enable ASWebAuthenticationSession.Callback.https support

* Revert some style changes

* Also allow universal links on macOS

* fix: apply some fixes

---------

Co-authored-by: Nico Mexis <nico.mexis@kabelmail.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThexXTURBOXx ThexXTURBOXx Awaiting requested review from ThexXTURBOXx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@GabrielDamasceno @ThexXTURBOXx