feat: handle parsing of pros and cons in array

ThianHooi · Jul 27, 2024 · e1e5ea3 · e1e5ea3
1 parent fa79dc3
commit e1e5ea3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/app/modules/dashboard/DataDrawer.tsx b/app/modules/dashboard/DataDrawer.tsx
@@ -18,6 +18,15 @@ const Title = ({ children }: { children: React.ReactNode }) => (
 );
 
 export function DataSheet({ open, onOpenChange, video }: Props) {
+  const parseProsCons = (prosCons: string | string[] | undefined) => {
+    if (!prosCons) return null;
+
+    if (Array.isArray(prosCons)) {
+      return prosCons.map((proCon, index) => <li key={index}>{proCon}</li>);
+    }
+    return <Markdown>{prosCons}</Markdown>;
+  };
+
   return (
     <Sheet open={open} onOpenChange={onOpenChange}>
       <SheetContent className="overflow-y-scroll min-w-[50vw]">
@@ -44,11 +53,11 @@ export function DataSheet({ open, onOpenChange, video }: Props) {
 
           <div>
             <Title>Pros</Title>
-            <Markdown>{video?.summary?.pros}</Markdown>
+            {parseProsCons(video?.summary?.pros)}
           </div>
           <div>
             <Title>Cons</Title>
-            <Markdown>{video?.summary?.cons}</Markdown>
+            {parseProsCons(video?.summary?.cons)}
           </div>
 
           <div>

diff --git a/app/modules/dashboard/columns.tsx b/app/modules/dashboard/columns.tsx
@@ -7,8 +7,8 @@ import GoogleMapAnchor from './GoogleMapAnchor';
 
 type Summary = {
   introduction?: Introduction;
-  pros?: string;
-  cons?: string;
+  pros?: string | string[];
+  cons?: string | string[];
   summary?: string;
 };
 
@@ -50,7 +50,6 @@ export const columns: ColumnDef<Video>[] = [
     header: 'Location',
   },
   {
-    accessorKey: 'location',
     header: 'Google Maps',
     cell: ({ row }) => (
       <GoogleMapAnchor