feat: check factory balance #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzalo-smtv
force-pushed
the
feat/check-factory-balance
branch
from
552ec1f to
c936496
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to error handling and balance checking mechanisms in
MachineSmartAccountandMachineStationFactorycontracts. The most important changes include adding additional parameters to theTargetCallFailederror, introducing a newInsufficientFactoryBalanceerror, and implementing balance checks before funding machine addresses.Error Handling Enhancements:
src/libs/Errors.sol: Updated theTargetCallFailederror to includebytes dataas an additional parameter and added a newInsufficientFactoryBalanceerror.Contract Updates:
src/machine-station/MachineSmartAccount.sol: Modified theTargetCallFailederror to includedatain theexecuteTransactionfunction.src/machine-station/MachineStationFactory.sol: Updated theTargetCallFailederror to includedatain theexecuteTransactionfunction.src/machine-station/MachineStationFactory.sol: Added a balance check for the factory before funding machine addresses and introduced theInsufficientFactoryBalanceerror.Agung Contract Updates:
src/machine-station/agung/MachineStationFactory.sol: Updated theTargetCallFailederror to includedatain theexecuteTransactionfunction.src/machine-station/agung/MachineStationFactory.sol: Added a balance check for the factory before funding machine addresses and introduced theInsufficientFactoryBalanceerror.ABI Update
examples/js/MachineStationFactoryABI.json: Updated abi file with new errors TargetCallFailed and InsufficientFactoryBalance