Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiarch images (arm64 and amd64) #15

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

iamjoemccormick
Copy link
Member

@iamjoemccormick iamjoemccormick commented Feb 27, 2024

Remaining Work

Checklist before merging:

  • Documentation: Has documentation been added for new functionality? Does any existing documentation need to be updated or removed?
  • Tests: Is there adequate test coverage for new functionality? Do any existing tests need to be updated?
  • Dependencies: Does this PR rely on any changes to dependencies? If so has the go.mod or equivalent been updated to point at a version that contains the related changes?
  • Git Hygiene: Is the commit history squashed down reasonably?

Which issue(s) does this PR address?

No associated issues.

Does this PR depend on any other PRs to be merged first?

No

What does this PR do / why do we need it?

BeeGFS has published packages for both amd64 and arm64 for some time and it makes sense to also publish container images for both architectures. We're doing this now because with ThinkParQ/beegfs-csi-driver#24 we added multiarch images for the BeeGFS CSI driver and operator. Now people can also deploy BeeGFS file systems into K8s clusters using arm64 nodes (and there is at least one user wanting to do so).

Where should the reviewer(s) start reviewing this?

Review changes to the GitHub actions workflow then Dockerfiles.

Are there any specific topics we should discuss before merging?

No

What are the next steps after this PR?

All work items for this task are complete with this PR.

@iamjoemccormick iamjoemccormick force-pushed the iamjoemccormick/support-multiarch-images branch 4 times, most recently from 8b46486 to 0f1e017 Compare February 27, 2024 17:36
@iamjoemccormick iamjoemccormick force-pushed the iamjoemccormick/support-multiarch-images branch from 0f1e017 to 47c7cac Compare February 27, 2024 18:16
@iamjoemccormick iamjoemccormick added ci/cd Additions or improvements to CI/CD workflows. enhancement New feature or request labels Feb 27, 2024
@iamjoemccormick iamjoemccormick self-assigned this Feb 27, 2024
Copy link
Collaborator

@pranavpadmasali pranavpadmasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@iamjoemccormick iamjoemccormick merged commit b9f3731 into main Feb 28, 2024
4 checks passed
@iamjoemccormick iamjoemccormick deleted the iamjoemccormick/support-multiarch-images branch February 28, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Additions or improvements to CI/CD workflows. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants