Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in step Function Signature and Usage #2

Open
dxyzx0 opened this issue May 27, 2024 · 0 comments
Open

Inconsistency in step Function Signature and Usage #2

dxyzx0 opened this issue May 27, 2024 · 0 comments

Comments

@dxyzx0
Copy link

dxyzx0 commented May 27, 2024

Dear Developers,

I am currently integrating some modules from your codebase, and I've come across an inconsistency that's causing some confusion. The step function in src/train_child.py is defined as follows:

def step(original_action, configs, Problem)
According to the documentation and source code, this function returns 11 values.

However, in annealing_generator.py, the step function is used differently:

reward_, t1, t2, nv1, nc1, nv2, nc2, solved_int1, total_int1, solved_int2, total_int2, obj1, obj2, real_obj1, real_obj2, nv1_origin, nc1_origin, nv2_origin, nc2_origin, e_reward1, e_reward2, primal_dual_integral_1, primal_dual_integral_2 = step(
    action,
    configs,
    Problem,
    instance_id,
    process_id)

Here, it appears that the function is expected to return 23 values.

Could you help clarify the correct usage of the step function? Specifically, are there additional parameters and return values that are not documented, or is there an error in the annealing_generator.py file?

Thank you for your assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant