forked from stellar/stellar-core
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Extract rust-toolchain.toml channel, pass to submodules (stellar#4518)
This is a somewhat crude but straightforward fix to the problem of version mismatches between the rust-toolchain.toml files stored in the stellar-core repo and those stored in the rs-soroban-env submodules: the makefile now extracts the channel name and appends it, explicitly, to all cargo invocations it makes. I.e. if stellar-core's `rust-toolchain.toml` file says `channel = "1.81.0"`, the makefile will run `cargo +1.81.0 build` in all the submodules, overriding whatever they have in their own `rust-toolchain.toml` files. We may wish to tweak this further, or to add additional build variants to the CI matrix of either this repo or rs-soroban-env, but I think this sort of "make sure they're all the same" step is basically going to be a part of any correct solution to the problem anyways, so I think we should probably at least start with it.
- Loading branch information
Showing
1 changed file
with
14 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters