Robmarti12/convert compile to static #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the ErrorListener instances in the Expression class and simplified the error handling process. These changes reduced redundancy and improved the readability of the code. Now, instead of using two separate ErrorListener instances to catch lexer and parser errors, we just throw an error in case parsing fails. Errors are now stored directly in an array in the Expression instance, simplifying access to them.
Refactored Expression.test.ts and JsonSerialize.test.ts to utilize HasErrors() function for clearer, more accurate error handling. Additionally, cleaned up unnecessary variable declarations in JsonSerialize.test.ts for better readability. These changes improve test robustness and clarity in code.
ThomasHambach
merged commit e1f3cbe
into
ThomasHambach:convert-compile-to-static
0 of 2 checks passed
ThomasHambach
added a commit
that referenced
this pull request
Aug 19, 2023
* Robmarti12/convert compile to static (#17) * Refactor error handling in Expression class Removed the ErrorListener instances in the Expression class and simplified the error handling process. These changes reduced redundancy and improved the readability of the code. Now, instead of using two separate ErrorListener instances to catch lexer and parser errors, we just throw an error in case parsing fails. Errors are now stored directly in an array in the Expression instance, simplifying access to them. * Refactor tests for better error handling and clean up Refactored Expression.test.ts and JsonSerialize.test.ts to utilize HasErrors() function for clearer, more accurate error handling. Additionally, cleaned up unnecessary variable declarations in JsonSerialize.test.ts for better readability. These changes improve test robustness and clarity in code. --------- Co-authored-by: robmarti12 <robin.martin@cmcitymedia.de> Co-authored-by: Thomas Hambach <thambach@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.