Feedback #12
Feedback #12
Conversation
added base of RepoCard
test branch
get Toms work
Tom changes
add favicon
|
✔️ Deploy Preview for repo-getter ready! 🔨 Explore the source changes: a5102d6 🔍 Inspect the deploy log: https://app.netlify.com/sites/repo-getter/deploys/6113e59c9f78310008569b49 😎 Browse the preview: https://deploy-preview-12--repo-getter.netlify.app |
zakgogi
left a comment
zakgogi
left a comment
There was a problem hiding this comment.
Really cool overall, really like the regexp matching stuff and the design in general, was hard to find something to criticise, good work
| setError(false); | ||
| window.location.pathname = `/${username}`; | ||
| } catch (error) { | ||
| setError('Unable to find GitHub user, please try again.'); |
There was a problem hiding this comment.
Cool that you handled the error here, when we did it we checked on the next page so we didn't have to fetch more than once but this is nicer I think
There was a problem hiding this comment.
Realised that because the error is handled here, if I just type an invalid username in the top bar it loads forever rather than using an error
| @@ -0,0 +1,33 @@ | |||
| import { screen } from '@testing-library/react'; | |||
There was a problem hiding this comment.
Nice that you added some tests
| @@ -0,0 +1,21 @@ | |||
| import React, { useState } from 'react'; | |||
| import { TextField } from '@material-ui/core'; | |||
There was a problem hiding this comment.
I've never used material-ui before, looks cool
| setLoading(false); | ||
| }, []) | ||
|
|
||
| function closeModal(){ |
There was a problem hiding this comment.
Cool that you used Modals, we just redirected to another page which was much less elegant
| import './style.css' | ||
|
|
||
| const Repos = () => { | ||
| const { username } = useParams(); |
| <Route path = '/:username'> | ||
| <Repos/> | ||
| </Route> | ||
| <Route path = '/'> |
There was a problem hiding this comment.
Feel like you potentially might need an exact in here?
There was a problem hiding this comment.
our plan was to send them back to the for in case of error
| @@ -0,0 +1,34 @@ | |||
| # Changelog | |||
There was a problem hiding this comment.
Nice readme, like that you used a gif
There was a problem hiding this comment.
I used ScreenToGif for Windowsx64 ;)
|
In agreement with Zak |
No description provided.