Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cbLibPath relocatable on sysimages, with RelocatableFolders. #100

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

ven-k
Copy link
Contributor

@ven-k ven-k commented Oct 23, 2023

On relocated sysimages, cbLibPath 's value has hardcoded source system's path. With RelocFolders, it will be relocatable.

@ThummeTo
Copy link
Owner

This is cool, thanks.
I will think about if we need to do that at other places, too.

@ashutosh-b-b
Copy link

ashutosh-b-b commented Oct 28, 2023

@ThummeTo can you create a branch corresponding to v0.12.2 release? It would be really helpful if we can get the above fix on top of that branch and then a patch release for v0.12.3.
CC: @sathvikbhagavan @ChrisRackauckas

@ThummeTo
Copy link
Owner

Yes, we can do that. I'm on it ...

@ThummeTo
Copy link
Owner

ThummeTo commented Oct 30, 2023

Please check if branch v0.12.3 is what you need.
The changes v0.12.2 to v0.12.3 can be seen here.

I am checking if the tests are still running (locally) right now. EDIT: Tests are running locally, seems fine.

@ashutosh-b-b
Copy link

Yes, that is the change we need. Thanks a lot!

@ThummeTo
Copy link
Owner

You're welcome!
Registration in progress!

@ThummeTo ThummeTo merged commit 39fc0d8 into ThummeTo:main Oct 30, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants