Skip to content

[DEVEXP] PHP 7.3 updates and fixes#21

Merged
mgrecotiendanube merged 3 commits intomasterfrom
devexp-php-73
Jan 16, 2026
Merged

[DEVEXP] PHP 7.3 updates and fixes#21
mgrecotiendanube merged 3 commits intomasterfrom
devexp-php-73

Conversation

@mgrecotiendanube
Copy link
Copy Markdown
Contributor

@mgrecotiendanube mgrecotiendanube commented Jan 16, 2026

Summary by CodeRabbit

  • Chores

    • Updated project dependencies to newer versions.
    • Upgraded GitHub Actions workflow configuration.
    • Updated Docker configuration and git settings.
  • Bug Fixes

    • Image optimizer now handles missing output paths gracefully by defaulting to input file location.
  • Tests

    • Enhanced test suite with improved parameter handling and type declarations.

✏️ Tip: You can customize this high-level summary in your review settings.

* Update production dependencies

- Production dependencies have the same versions as the monolith

* Remove dev minimum stability

* Update to phpunit 9

* Update Go download link

* Update image optimizer and webp-convert dependencies
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 16, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

PR updates Docker configuration by removing a PHP ini override and fixing a Go download URL, bumps composer dependencies, upgrades GitHub Actions checkout action to v6, adds a .gitignore rule for Snyk artifacts, and implements default output path logic in the image optimizer with corresponding test adjustments.

Changes

Cohort / File(s) Summary
Docker Configuration
.docker/php-cli/Dockerfile, .docker/php-cli/php-ini-overrides-phpdbg.ini
Updated Go download URL from googleapis.com to go.dev, removed COPY instruction for php-ini-overrides-phpdbg.ini, and deleted the associated sendmail_path configuration entry.
CI/CD
.github/workflows/php.yml
Upgraded GitHub Actions checkout action from v2 to v6 in two workflow steps.
Git Configuration
.gitignore
Added ignore rule for Snyk AI-generated rules file (.cursor/rules/snyk_rules.mdc).
Dependency Management
composer.json
Removed minimum-stability dev flag, bumped spatie/image-optimizer from ^1.1 to ^1.8, rosell-dk/webp-convert from ^2.4 to ^2.9, and phpunit/phpunit from ^8.5 to ^9.6.
Image Optimizer Logic
src/DefaultImageOptimizer.php, tests/DefaultImageOptimizerTest.php
Added default behavior: when output path is null, use input image path as output. Updated test method signature to accept two additional parameters ($convertInput, $convertOutput) with void return type and adjusted test data accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb54dc8 and 38ad383.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (7)
  • .docker/php-cli/Dockerfile
  • .docker/php-cli/php-ini-overrides-phpdbg.ini
  • .github/workflows/php.yml
  • .gitignore
  • composer.json
  • src/DefaultImageOptimizer.php
  • tests/DefaultImageOptimizerTest.php

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@mgrecotiendanube mgrecotiendanube merged commit f133fae into master Jan 16, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants