Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't round numbers in typst #26

Merged
merged 3 commits into from
Sep 11, 2024
Merged

fix: don't round numbers in typst #26

merged 3 commits into from
Sep 11, 2024

Conversation

lajp
Copy link
Member

@lajp lajp commented Sep 9, 2024

No description provided.

@lajp lajp linked an issue Sep 9, 2024 that may be closed by this pull request
Fix calculating issue in invoice generator Tietokilta/web#480
Closed
joonatanaatos
joonatanaatos requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@joonatanaatos joonatanaatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It breaks when price < 1

@lajp lajp requested a review from joonatanaatos September 11, 2024 13:56
joonatanaatos
joonatanaatos approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@joonatanaatos joonatanaatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joonatanaatos joonatanaatos merged commit 5823a5f into main Sep 11, 2024
9 checks passed
@lajp lajp deleted the typst-fix branch October 13, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonatanaatos joonatanaatos joonatanaatos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix calculating issue in invoice generator
3 participants
@lajp @joonatanaatos @kahlstrm