[Fix/Enhancement] Adding default argument current time timestamp in open 'w' mode #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #11544: Create and load of ml model should always pass timestamp to enable time travelling. |
ktsitsi
requested review from
gsakkis and
georgeSkoumas
and removed request for
gsakkis
gsakkis
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
As @thetorpedodog commented on one of the linked PRs, this is a temporary workaround, right? If so just add a TODO to remove it.
georgeSkoumas
approved these changes
Nov 16, 2021
ktsitsi
force-pushed
the
kt/sc-11544/hotfix-pass-timestamp-model
branch
from
b9b794c to
eb58945
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We modify each
openoperation adding current timestamp argument, when modifying/writing arrays to patch the bug described in the ticket below. This patch needs the upgrade of TileDB-Py to its currently latest release being 0.11.0 without it the issue persists due to the array.create function that was patched in the aforementioned release.Files changed: