Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 1.19 and remove redundant runtime requirements #13

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

jdblischak
Copy link
Collaborator

@jdblischak jdblischak self-assigned this Jan 3, 2024
@jdblischak
Copy link
Collaborator Author

It turns out that the run requirements were recently removed when updating to version in 1.19 in PR bioconda/bioconda-recipes#44774, so this PR essentially mirrors that one

@jdblischak
Copy link
Collaborator Author

To demonstrate why the run requirements are redundant, I rendered the recipe locally with

conda render --override-channels -c conda-forge -c tiledb recipe/

Here are the results for libcurl 8 and libdeflate 1.16. All the shared libraries are properly pinned in run due to their run exports. The only exception is that zlib exports libzlib at runtime (an artifact of how the conda-forge recipe for zlib is organized)

--------------
Hash contents:
--------------
{'c_compiler': 'gcc',
 'channel_targets': 'tiledb main',
 'libcurl': '8',
 'libdeflate': '1.16',
 'openssl': '3',
 'target_platform': 'linux-64'}
----------
meta.yaml:
----------
package:
  name: htslib
  version: '1.19'
source:
  sha256: 8751c40c4fa7d1f23a6864c5b20a73744f8be68239535ae7729c5f7d394d0736
  url: https://github.com/samtools/htslib/releases/download/1.19/htslib-1.19.tar.bz2
build:
  number: '0'
  run_exports:
    - htslib >=1.19,<1.20.0a0
requirements:
  build:
    - ld_impl_linux-64 2.40 h41732ed_0
    - kernel-headers_linux-64 2.6.32 he073ed8_16
    - libstdcxx-ng 13.2.0 h7e041cc_3
    - libgomp 13.2.0 h807b86a_3
    - binutils_linux-64 2.40 hbdbef99_2
    - libgcc-ng 13.2.0 h807b86a_3
    - libsanitizer 13.2.0 h7e041cc_3
    - binutils_impl_linux-64 2.40 hf600244_0
    - make 4.3 hd18ef5c_1
    - gcc_linux-64 13.2.0 h112eaf3_2
    - _openmp_mutex 4.5 2_gnu
    - sysroot_linux-64 2.12 he073ed8_16
    - _libgcc_mutex 0.1 conda_forge
    - gcc_impl_linux-64 13.2.0 h338b0a0_3
    - libgcc-devel_linux-64 13.2.0 ha9c7c90_103
  host:
    - _libgcc_mutex 0.1 conda_forge
    - ca-certificates 2023.11.17 hbcca054_0
    - libstdcxx-ng 13.2.0 h7e041cc_3
    - libgomp 13.2.0 h807b86a_3
    - _openmp_mutex 4.5 2_gnu
    - libgcc-ng 13.2.0 h807b86a_3
    - bzip2 1.0.8 hd590300_5
    - c-ares 1.24.0 hd590300_0
    - keyutils 1.6.1 h166bdaf_0
    - libdeflate 1.16 h0b41bf4_0
    - libev 4.33 hd590300_2
    - libzlib 1.2.13 hd590300_5
    - ncurses 6.4 h59595ed_2
    - openssl 3.2.0 hd590300_1
    - xz 5.2.6 h166bdaf_0
    - libedit 3.1.20191231 he28a2e2_2
    - libnghttp2 1.58.0 h47da74e_1
    - libssh2 1.11.0 h0841786_0
    - zlib 1.2.13 hd590300_5
    - zstd 1.5.5 hfc55251_0
    - krb5 1.21.2 h659d440_0
    - libcurl 8.5.0 hca28451_0
  run:
    - xz >=5.2.6,<6.0a0
    - bzip2 >=1.0.8,<2.0a0
    - libzlib >=1.2.13,<1.3.0a0
    - libgcc-ng >=13
    - libdeflate >=1.16,<1.17.0a0
    - openssl >=3.2.0,<4.0a0
    - libcurl >=8.5.0,<9.0a0
test:
  commands:
    - ldd $PREFIX/bin/bgzip | grep deflate
    - test -e test1.bed || printf 'chr1\t100\t200\n' > test1.bed
    - bgzip test1.bed
    - tabix test1.bed.gz
    - htsfile test1.bed.gz
  files:
    - test1.bed
about:
  doc_url: http://www.htslib.org/
  home: https://github.com/samtools/htslib
  license: MIT
  license_family: MIT
  license_file: LICENSE
  summary: C library for high-throughput sequencing data formats.
extra:
  copy_test_source_files: true
  final: true
  recipe-maintainers:
    - shelnutt2
    - jdblischak

@jdblischak jdblischak merged commit a6a90b0 into TileDB-Inc:main Jan 3, 2024
36 checks passed
@jdblischak jdblischak deleted the htslib-1.19 branch January 3, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants